Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Bonus Pagamenti Digitali): [#175117682] Citizen delete response cannot be decoded #2265

Merged
merged 9 commits into from
Oct 7, 2020

Conversation

Undermaken
Copy link
Contributor

@Undermaken Undermaken commented Oct 6, 2020

Short description

This PR change the decoders and statuses coded related do delete request
It also handles the delete in enabled reducer

how to test

  • on production (bpdEnabled = true)
  • locally by get the last commit of io-dev-api-server

@pagopa-github-bot pagopa-github-bot changed the title [#175117682] Citizen delete response cannot be decoded fix(Bonus Pagamenti Digitali): [#175117682] Citizen delete response cannot be decoded Oct 6, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 6, 2020

Affected stories

  • 🐞 #175117682: La disiscrizione del cittadino da bpd ritorna sempre errore

Generated by 🚫 dangerJS against 13aab3d

@Undermaken Undermaken marked this pull request as ready for review October 6, 2020 09:57
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2020

Codecov Report

Merging #2265 into master will decrease coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2265      +/-   ##
==========================================
- Coverage   47.83%   47.82%   -0.01%     
==========================================
  Files         539      539              
  Lines       15640    15643       +3     
  Branches     3138     3139       +1     
==========================================
+ Hits         7481     7482       +1     
- Misses       8118     8120       +2     
  Partials       41       41              
Impacted Files Coverage Δ
ts/features/bonus/bpd/saga/networking/index.ts 47.05% <ø> (ø)
...nus/bpd/store/reducers/details/activation/index.ts 56.00% <33.33%> (-4.87%) ⬇️
ts/features/bonus/bpd/api/backendBpdClient.ts 37.77% <100.00%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca95f05...d8a03a6. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

Merging #2265 into master will decrease coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2265      +/-   ##
==========================================
- Coverage   47.83%   47.83%   -0.01%     
==========================================
  Files         541      541              
  Lines       15720    15723       +3     
  Branches     3150     2896     -254     
==========================================
+ Hits         7520     7521       +1     
- Misses       8158     8160       +2     
  Partials       42       42              
Impacted Files Coverage Δ
ts/features/bonus/bpd/saga/networking/index.ts 47.05% <ø> (ø)
...nus/bpd/store/reducers/details/activation/index.ts 56.00% <33.33%> (-4.87%) ⬇️
ts/features/bonus/bpd/api/backendBpdClient.ts 37.77% <100.00%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 312eeef...13aab3d. Read the comment docs.

@fabriziofff fabriziofff merged commit 5520010 into master Oct 7, 2020
@fabriziofff fabriziofff deleted the 175117682-fix-bpd-delete branch October 7, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants