Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#175115845] Add networking and store logic to support pans search #2263

Merged
merged 15 commits into from
Oct 8, 2020

Conversation

Undermaken
Copy link
Contributor

@Undermaken Undermaken commented Oct 5, 2020

Short description

This PR adds all stuffs needed to support pans search

  • handle API request/response /bancomat/pans
  • patch response Cards because Card has a wrong codec auto-generated
  • add new store section wallet.bancomat. This section now contains only onboarding.pans sections to hold pans array derived from pans search

how to test

@Undermaken Undermaken changed the title [#175115845] Add networking and store for support pans search [#175115845] Add networking and store logic to support pans search Oct 5, 2020
@pagopa-github-bot pagopa-github-bot changed the title [#175115845] Add networking and store logic to support pans search feat(Bonus Pagamenti Digitali): [#175115845] Add networking and store logic to support pans search Oct 5, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 5, 2020

Affected stories

  • 🌟 #175115845: Aggiungere la logica di networking e di store per ottenere i pans del cittadino

Generated by 🚫 dangerJS against 3e1def8

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2020

Codecov Report

Merging #2263 into master will increase coverage by 0.06%.
The diff coverage is 71.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2263      +/-   ##
==========================================
+ Coverage   47.83%   47.89%   +0.06%     
==========================================
  Files         539      541       +2     
  Lines       15640    15689      +49     
  Branches     3138     3147       +9     
==========================================
+ Hits         7481     7515      +34     
- Misses       8118     8133      +15     
  Partials       41       41              
Impacted Files Coverage Δ
...s/wallet/onboarding/bancomat/store/reducers/abi.ts 46.42% <ø> (ø)
ts/api/pagopa.ts 32.07% <33.33%> (+0.07%) ⬆️
...allet/onboarding/bancomat/saga/networking/index.ts 42.85% <42.85%> (-7.15%) ⬇️
...ing/bancomat/store/reducers/bancomat/onboarding.ts 64.70% <64.70%> (ø)
ts/sagas/wallet.ts 19.07% <66.66%> (-0.13%) ⬇️
ts/features/bonus/bpd/api/patchedTypes.ts 100.00% <100.00%> (ø)
ts/features/bonus/bpd/model/RemoteValue.ts 91.66% <100.00%> (+1.66%) ⬆️
.../wallet/onboarding/bancomat/store/actions/index.ts 100.00% <100.00%> (ø)
...boarding/bancomat/store/reducers/bancomat/index.ts 100.00% <100.00%> (ø)
ts/store/reducers/wallet/index.ts 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca95f05...a23a9f7. Read the comment docs.

@Undermaken Undermaken marked this pull request as ready for review October 5, 2020 11:56
@@ -20,14 +23,16 @@ export type WalletState = Readonly<{
payment: PaymentState;
pspsById: PspStateById;
abi: AbiState;
bancomat: BancomatState;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the store path from wallet/bancomat/onboarding/pans to wallet/onboarding/bancomat/pans just to follow the project foldering?

@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

Merging #2263 into master will increase coverage by 0.06%.
The diff coverage is 71.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2263      +/-   ##
==========================================
+ Coverage   47.85%   47.92%   +0.06%     
==========================================
  Files         541      543       +2     
  Lines       15736    15785      +49     
  Branches     2896     3158     +262     
==========================================
+ Hits         7531     7565      +34     
- Misses       8163     8178      +15     
  Partials       42       42              
Impacted Files Coverage Δ
...s/wallet/onboarding/bancomat/store/reducers/abi.ts 46.42% <ø> (ø)
ts/api/pagopa.ts 32.07% <33.33%> (+0.07%) ⬆️
...allet/onboarding/bancomat/saga/networking/index.ts 42.85% <42.85%> (-7.15%) ⬇️
...ing/bancomat/store/reducers/bancomat/onboarding.ts 64.70% <64.70%> (ø)
ts/sagas/wallet.ts 19.07% <66.66%> (-0.13%) ⬇️
ts/features/bonus/bpd/api/patchedTypes.ts 100.00% <100.00%> (ø)
ts/features/bonus/bpd/model/RemoteValue.ts 91.66% <100.00%> (+1.66%) ⬆️
.../wallet/onboarding/bancomat/store/actions/index.ts 100.00% <100.00%> (ø)
...boarding/bancomat/store/reducers/bancomat/index.ts 100.00% <100.00%> (ø)
ts/store/reducers/wallet/index.ts 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d208ae...3e1def8. Read the comment docs.

@fabriziofff fabriziofff merged commit cd92644 into master Oct 8, 2020
@fabriziofff fabriziofff deleted the 175115845-pans-search branch October 8, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants