Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#174863094] No payment methods available screen #2262

Merged
merged 69 commits into from
Oct 7, 2020

Conversation

fabriziofff
Copy link
Contributor

This pr depends on #2261

Short description

This pr updates NoPaymentMethodsAvailableScreen and uses it as default landing screen after the iban insertion in the onboarding phase.

List of changes proposed in this pull request

  • Update NoPaymentMethodsAvailableScreen following the design specification.
  • Temporary changed default landing screen to NoPaymentMethodsAvailableScreen after IBAN insertion (or skip), in order to complete the workflow.

How to test

The screen can be viewed using the action navigateToBpdOnboardingNoPaymentMethods or completing the onboarding workflow.

fabriziofff and others added 30 commits September 29, 2020 17:35
@pagopa-github-bot pagopa-github-bot changed the title [#174863094] No payment methods available screen feat(Bonus Pagamenti Digitali): [#174863094] No payment methods available screen Oct 5, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 5, 2020

Affected stories

  • 🌟 #174863094: Creare schermata non ci sono metodi di pagamento, aggiungi un metodo di pagamento

Generated by 🚫 dangerJS against a992a43

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2020

Codecov Report

Merging #2262 into master will increase coverage by 0.09%.
The diff coverage is 74.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2262      +/-   ##
==========================================
+ Coverage   47.83%   47.92%   +0.09%     
==========================================
  Files         539      541       +2     
  Lines       15640    15712      +72     
  Branches     3136     3143       +7     
==========================================
+ Hits         7481     7530      +49     
- Misses       8118     8140      +22     
- Partials       41       42       +1     
Impacted Files Coverage Δ
...usVacanze/components/markdown/FooterTwoButtons.tsx 50.00% <0.00%> (-7.15%) ⬇️
...tivation/request/ActivateBonusRequestComponent.tsx 68.00% <ø> (ø)
...ns/onboarding/declaration/DeclarationComponent.tsx 56.25% <ø> (ø)
...re/reducers/details/activation/payoffInstrument.ts 51.21% <0.00%> (-2.63%) ⬇️
...eatures/bonus/bpd/saga/orchestration/insertIban.ts 48.27% <33.33%> (ø)
...tures/bonus/bpd/screens/iban/IbanLoadingUpsert.tsx 57.14% <33.33%> (-0.76%) ⬇️
ts/components/core/typography/BaseTypography.tsx 92.85% <66.66%> (-7.15%) ⬇️
.../screens/iban/insertion/IbanInsertionComponent.tsx 68.18% <68.18%> (ø)
...bpd/screens/iban/insertion/IbanInsertionScreen.tsx 72.72% <72.72%> (ø)
...features/bonus/bpd/screens/iban/ko/IbanKOWrong.tsx 77.27% <77.27%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a06825f...82dcae6. Read the comment docs.

Copy link
Contributor

@Undermaken Undermaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be merged after #2261

locales/it/index.yml Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Oct 7, 2020

Codecov Report

Merging #2262 into master will increase coverage by 0.03%.
The diff coverage is 77.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2262      +/-   ##
==========================================
+ Coverage   47.83%   47.86%   +0.03%     
==========================================
  Files         541      541              
  Lines       15722    15738      +16     
  Branches     2896     2896              
==========================================
+ Hits         7520     7533      +13     
- Misses       8160     8163       +3     
  Partials       42       42              
Impacted Files Coverage Δ
.../screens/iban/insertion/IbanInsertionComponent.tsx 68.18% <ø> (ø)
...eatures/bonus/bpd/saga/orchestration/insertIban.ts 48.27% <33.33%> (ø)
...ens/onboarding/NoPaymentMethodsAvailableScreen.tsx 84.21% <83.33%> (-15.79%) ⬇️
ts/features/bonus/bpd/navigation/navigator.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a180b73...a992a43. Read the comment docs.

@Undermaken Undermaken merged commit 6fda0ec into master Oct 7, 2020
@Undermaken Undermaken deleted the 174863094-NoPaymentMethodsAvailableScreen branch October 7, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants