Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#174847335,#174847371,#174847398] Iban ko screens #2261

Merged
merged 58 commits into from
Oct 7, 2020

Conversation

fabriziofff
Copy link
Contributor

@fabriziofff fabriziofff commented Oct 5, 2020

This pr depends on #2259

Short description

This pr adds all the ko screens for the IBAN insertion.

IbanKoWrong IbanKoCannotVerify IbanKoNotOwned

List of changes proposed in this pull request

  • Fix a bug for BaseTypography (styles received not applied)
  • Changed FooterTwoButtons to support also the layout TwoButtonsInlineHalf (waiting to create a new core component)
  • Modified IbanKOCannotVerify, IbanKoNotOwned and IbanKoWrong in order to reflect the design.
  • Fix a bug in paymentInstrumentUpsertReducer (when receive a 200 - IbanStatus.NOT_VALID the value was cleared).

How to test

  • The IBAN insertion flow is reachable from everywhere, just need to dispatch the action bpdIbanInsertionStart() and try different response from the dev server.

fabriziofff and others added 30 commits September 29, 2020 17:35
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2020

Codecov Report

Merging #2261 into master will increase coverage by 0.05%.
The diff coverage is 73.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2261      +/-   ##
==========================================
+ Coverage   47.83%   47.89%   +0.05%     
==========================================
  Files         539      541       +2     
  Lines       15640    15696      +56     
  Branches     3136     3145       +9     
==========================================
+ Hits         7481     7517      +36     
- Misses       8118     8137      +19     
- Partials       41       42       +1     
Impacted Files Coverage Δ
...usVacanze/components/markdown/FooterTwoButtons.tsx 50.00% <0.00%> (-7.15%) ⬇️
...tivation/request/ActivateBonusRequestComponent.tsx 68.00% <ø> (ø)
...ns/onboarding/declaration/DeclarationComponent.tsx 56.25% <ø> (ø)
...re/reducers/details/activation/payoffInstrument.ts 51.21% <0.00%> (-2.63%) ⬇️
...tures/bonus/bpd/screens/iban/IbanLoadingUpsert.tsx 57.14% <33.33%> (-0.76%) ⬇️
ts/components/core/typography/BaseTypography.tsx 92.85% <66.66%> (-7.15%) ⬇️
.../screens/iban/insertion/IbanInsertionComponent.tsx 68.18% <68.18%> (ø)
...bpd/screens/iban/insertion/IbanInsertionScreen.tsx 72.72% <72.72%> (ø)
...features/bonus/bpd/screens/iban/ko/IbanKOWrong.tsx 77.27% <77.27%> (ø)
...s/bonus/bpd/screens/iban/ko/IbanKOCannotVerify.tsx 80.95% <80.95%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a06825f...e1f75f8. Read the comment docs.

@fabriziofff fabriziofff marked this pull request as ready for review October 5, 2020 09:14
Copy link
Contributor

@Undermaken Undermaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be merged after #2259

@codecov-io
Copy link

Codecov Report

Merging #2261 into master will increase coverage by 0.04%.
The diff coverage is 76.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2261      +/-   ##
==========================================
+ Coverage   47.79%   47.83%   +0.04%     
==========================================
  Files         540      541       +1     
  Lines       15680    15720      +40     
  Branches     3145     2895     -250     
==========================================
+ Hits         7494     7520      +26     
- Misses       8145     8158      +13     
- Partials       41       42       +1     
Impacted Files Coverage Δ
...usVacanze/components/markdown/FooterTwoButtons.tsx 50.00% <0.00%> (-7.15%) ⬇️
...re/reducers/details/activation/payoffInstrument.ts 51.21% <0.00%> (-2.63%) ⬇️
...tures/bonus/bpd/screens/iban/IbanLoadingUpsert.tsx 57.14% <33.33%> (-0.76%) ⬇️
ts/components/core/typography/BaseTypography.tsx 92.85% <66.66%> (-7.15%) ⬇️
...features/bonus/bpd/screens/iban/ko/IbanKOWrong.tsx 77.27% <77.27%> (ø)
...s/bonus/bpd/screens/iban/ko/IbanKOCannotVerify.tsx 80.95% <80.95%> (ø)
...tures/bonus/bpd/screens/iban/ko/IbanKONotOwned.tsx 80.95% <80.95%> (ø)
.../features/bonus/bpd/screens/iban/ko/IbanKoBody.tsx 81.25% <81.25%> (ø)
...features/bonus/bpd/screens/iban/MainIbanScreen.tsx 45.94% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13d2999...27210bc. Read the comment docs.

@Undermaken Undermaken merged commit adf9337 into master Oct 7, 2020
@fabriziofff fabriziofff deleted the 174847335-IbanKOWrong branch January 21, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants