Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Bonus Pagamenti Digitali): [#175096847] Support internal tests #2260

Merged
merged 8 commits into from
Oct 5, 2020

Conversation

Undermaken
Copy link
Contributor

@Undermaken Undermaken commented Oct 2, 2020

Short description

This PR adds/edits all stuffs needed to support internal tests

  • add bpd api key and bpd endpoint in .env files
  • add a temporary bpd token generator (based on bpd test environment)
  • implement delete api with relative actions (note: it fails on response decoding but the request goes successfully)
  • add leave bpd button on developer section

@Undermaken Undermaken requested a review from fabriziofff October 2, 2020 18:06
@pagopa-github-bot pagopa-github-bot changed the title [#175096847] Support internal tests feat(Bonus Pagamenti Digitali): [#175096847] Support internal tests Oct 2, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 2, 2020

Affected stories

  • 🌟 #175096847: Aggiungere il recupero del token di accesso per test interni

Generated by 🚫 dangerJS against 84ba5ce

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2020

Codecov Report

Merging #2260 into master will increase coverage by 0.00%.
The diff coverage is 53.84%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2260   +/-   ##
=======================================
  Coverage   47.82%   47.83%           
=======================================
  Files         538      539    +1     
  Lines       15612    15640   +28     
  Branches     3135     3138    +3     
=======================================
+ Hits         7467     7481   +14     
- Misses       8104     8118   +14     
  Partials       41       41           
Impacted Files Coverage Δ
ts/features/bonus/bpd/api/backendBpdClient.ts 36.36% <38.46%> (+0.25%) ⬆️
ts/features/bonus/bpd/saga/networking/index.ts 47.05% <40.00%> (-6.79%) ⬇️
ts/screens/profile/ProfileMainScreen.tsx 27.81% <40.00%> (-0.08%) ⬇️
ts/features/bonus/bpd/saga/index.ts 60.00% <55.55%> (-5.00%) ⬇️
ts/config.ts 100.00% <100.00%> (ø)
ts/features/bonus/bpd/api/patchedTypes.ts 100.00% <100.00%> (ø)
ts/features/bonus/bpd/store/actions/onboarding.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1546d5...84ba5ce. Read the comment docs.

@Undermaken Undermaken marked this pull request as ready for review October 2, 2020 18:20
@fabriziofff fabriziofff merged commit a06825f into master Oct 5, 2020
@fabriziofff fabriziofff deleted the 175096847-support-bdp-internal-tests branch January 21, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants