feat(Bonus Pagamenti Digitali): [#174847319] Iban insertion screen #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-store-reducers
…tion-store-reducers
…on-store-reducers
…on-store-reducers
pagopa-github-bot
changed the title
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2259 +/- ##
==========================================
+ Coverage 47.83% 47.84% +0.01%
==========================================
Files 539 540 +1
Lines 15640 15656 +16
Branches 3136 3140 +4
==========================================
+ Hits 7481 7491 +10
- Misses 8118 8124 +6
Partials 41 41
Continue to review full report at Codecov.
|
fabriziofff
requested review from
CrisTofani,
francescopersico and
Undermaken
as code owners
…on-store-reducers
…anInsertionScreen
…d.ts Co-authored-by: Matteo Boschi <[email protected]>
Co-authored-by: Matteo Boschi <[email protected]>
…anInsertionScreen
Codecov Report
@@ Coverage Diff @@
## master #2259 +/- ##
==========================================
+ Coverage 47.83% 47.84% +0.01%
==========================================
Files 539 540 +1
Lines 15640 15656 +16
Branches 3138 2885 -253
==========================================
+ Hits 7481 7491 +10
- Misses 8118 8124 +6
Partials 41 41
Continue to review full report at Codecov.
|
Undermaken
suggested changes
Oct 7, 2020
|
|
||
| export const IbanInsertionComponent: React.FunctionComponent<Props> = props => { | ||
| const [iban, setIban] = useState(""); | ||
| const isInvalidIban = iban.length > 0 && Iban.decode(iban).isLeft(); |
There was a problem hiding this comment.
Suggested change
| const isInvalidIban = iban.length > 0 && Iban.decode(iban).isLeft(); | |
| const isInvalidIban = Iban.decode(iban).isLeft(); |
Iban.decode("") -> left
There was a problem hiding this comment.
I did this to avoid that when the user enter in the screen the first time (iban.length===0) immediately sees the error graphic without having started entering text yet.
What you think?
| export const IbanInsertionComponent: React.FunctionComponent<Props> = props => { | ||
| const [iban, setIban] = useState(""); | ||
| const isInvalidIban = iban.length > 0 && Iban.decode(iban).isLeft(); | ||
| const userCanContinue = !isInvalidIban && iban.length > 0; |
There was a problem hiding this comment.
Suggested change
| const userCanContinue = !isInvalidIban && iban.length > 0; | |
| const userCanContinue = !isInvalidIban; |
There was a problem hiding this comment.
Same reason as in the previous comment
ts/features/bonus/bpd/screens/iban/insertion/IbanInsertionComponent.tsx
Outdated
Show resolved
Hide resolved
ts/features/bonus/bpd/screens/iban/insertion/IbanInsertionComponent.tsx
Outdated
Show resolved
Hide resolved
…onent.tsx Co-authored-by: Matteo Boschi <[email protected]>
…onent.tsx Co-authored-by: Matteo Boschi <[email protected]>
Undermaken
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr depends on #2252
Short description
This pr adds the
IbanInsertionScreen.List of changes proposed in this pull request
IbanInsertionComponent, the graphical component that allows the insertion of an IBAN.Before trying to register the Iban and have the remote result, it is checked that the text entered is decodable according to the
Ibantype. The maximum size is set to 34 (maximum length of an IBAN) although an Italian iban has a maximum length of 27FooterTwoButtons.tsxin order to support a left text for the button.How to test
bpdIbanInsertionStart()