Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [#174976615] Rename and move CTA components #2235

Merged
merged 4 commits into from
Sep 29, 2020

Conversation

CrisTofani
Copy link
Contributor

Short description

This PR aims to rename and move CTA components from feature scoped directory of messages to generic components since it is used by Services too

@pagopa-github-bot pagopa-github-bot changed the title [#174976615] Rename and move CTA components chore: [#174976615] Rename and move CTA components Sep 28, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Sep 28, 2020

Warnings
⚠️

Multiple labels match the expression /(changelog-scope:|epic-)(.*)/m for the story [#174976615].

   It is not possible to assign a single scope to this pull request!

Affected stories

  • ⚙️ #174976615: Rinominare MessageNestedCTABar e i relativi sotto-componenti

Generated by 🚫 dangerJS against 40446b3

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2020

Codecov Report

Merging #2235 into master will not change coverage.
The diff coverage is 72.72%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2235   +/-   ##
=======================================
  Coverage   47.56%   47.56%           
=======================================
  Files         523      523           
  Lines       15323    15323           
  Branches     3094     3096    +2     
=======================================
  Hits         7289     7289           
  Misses       7993     7993           
  Partials       41       41           
Impacted Files Coverage Δ
ts/components/messages/MessageListCTABar.tsx 31.25% <50.00%> (ø)
ts/components/cta/ExtractedCTABar.tsx 35.29% <60.00%> (ø)
ts/components/cta/ExtractedCtaButton.tsx 50.00% <100.00%> (ø)
ts/components/messages/MessageDetailCTABar.tsx 30.76% <100.00%> (ø)
...screens/profile/playgrounds/MarkdownPlayground.tsx 47.36% <100.00%> (ø)
ts/screens/services/ServiceDetailsScreen.tsx 23.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7af639...40446b3. Read the comment docs.

@Undermaken Undermaken merged commit b2f3071 into master Sep 29, 2020
@CrisTofani CrisTofani deleted the 174976615-rename-cta-components branch March 23, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants