Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MyPortal): [#174865280] Clean stored navigation params #2227

Merged
merged 7 commits into from
Oct 1, 2020

Conversation

CrisTofani
Copy link
Contributor

Short description

This PR clean the store informations of internalRouteNavigation from routeName and params ones the user leaves the ServiceWebviewScreen

@pagopa-github-bot pagopa-github-bot changed the title [#174865280] Clean stored navigation params feat(MyPortal): [#174865280] Clean stored navigation params Sep 25, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Sep 25, 2020

Affected stories

  • 🌟 #174865280: Come APP quando esco dallo screen con la webview voglio pulire lo store dai parametri di navigazione

Generated by 🚫 dangerJS against a12774d

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2020

Codecov Report

Merging #2227 into master will decrease coverage by 0.00%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2227      +/-   ##
==========================================
- Coverage   47.57%   47.56%   -0.01%     
==========================================
  Files         523      523              
  Lines       15320    15328       +8     
  Branches     2840     3097     +257     
==========================================
+ Hits         7288     7291       +3     
- Misses       7991     7995       +4     
- Partials       41       42       +1     
Impacted Files Coverage Δ
ts/screens/services/ServicesWebviewScreen.tsx 34.92% <20.00%> (-0.08%) ⬇️
ts/store/reducers/internalRouteNavigation.ts 72.22% <50.00%> (-13.50%) ⬇️
ts/store/actions/internalRouteNavigation.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7bf206...a12774d. Read the comment docs.

@Undermaken Undermaken merged commit 5b556b8 into master Oct 1, 2020
@Undermaken Undermaken deleted the 174865280-clean-store-cta-params branch October 1, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants