Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Payments): [#174804073] Show IUV label for notice code #2223

Merged
merged 2 commits into from
Sep 25, 2020

Conversation

Undermaken
Copy link
Contributor

@Undermaken Undermaken commented Sep 23, 2020

Short description

Notice code should be shown related to transaction paymentNoticeNumber
This PR also improve the UI of VersionInfoOverlay component

before now
before now

improve version overlay
@pagopa-github-bot pagopa-github-bot changed the title [#174804073] IUV label for notice code fix(Payments): [#174804073] IUV label for notice code Sep 23, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Sep 23, 2020

Affected stories

  • 🐞 #174804073: [minor] Nel riepilogo avviso di Pagamento viene mostrato il Codice Avviso ma viene erroneamente chiamato Codice IUV

Generated by 🚫 dangerJS against 6156c34

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2020

Codecov Report

Merging #2223 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2223   +/-   ##
=======================================
  Coverage   47.20%   47.21%           
=======================================
  Files         502      503    +1     
  Lines       14992    14953   -39     
  Branches     3046     3036   -10     
=======================================
- Hits         7077     7060   -17     
+ Misses       7873     7851   -22     
  Partials       42       42           
Impacted Files Coverage Δ
...creens/wallet/payment/TransactionSummaryScreen.tsx 18.63% <ø> (ø)
ts/utils/messages.ts 51.16% <0.00%> (-4.40%) ⬇️
ts/components/messages/MessageDetailCTABar.tsx 28.20% <0.00%> (-2.57%) ⬇️
ts/components/messages/MessageNestedCTABar.tsx 33.33% <0.00%> (-1.97%) ⬇️
ts/components/messages/MessageListCTABar.tsx 29.41% <0.00%> (-1.84%) ⬇️
ts/screens/onboarding/PinScreen.tsx 19.81% <0.00%> (-0.35%) ⬇️
ts/screens/profile/ProfileMainScreen.tsx 29.07% <0.00%> (-0.21%) ⬇️
ts/sagas/startup.ts 58.64% <0.00%> (-0.14%) ⬇️
ts/sagas/identification.ts 32.60% <0.00%> (-0.05%) ⬇️
ts/sagas/startup/watchPinResetSaga.ts 63.63% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e38164...6156c34. Read the comment docs.

@Undermaken Undermaken marked this pull request as ready for review September 23, 2020 18:15
@Undermaken Undermaken changed the title fix(Payments): [#174804073] IUV label for notice code fix(Payments): [#174804073] Show IUV label for notice code Sep 23, 2020
@fabriziofff fabriziofff merged commit 89859af into master Sep 25, 2020
@fabriziofff fabriziofff deleted the 174804073-change-transaction-summary-label branch September 25, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants