Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MyPortal): [#174859517] Checks token_name on CTA actions #2208

Merged
merged 24 commits into from
Sep 25, 2020

Conversation

CrisTofani
Copy link
Contributor

Short description

This PR adds the service to NestedCTA components to check if the service is available and it can follow the link to services webview screen

@pagopa-github-bot pagopa-github-bot changed the title [#174859517] Checks token_name on CTA actions feat(MyPortal): [#174859517] Checks token_name on CTA actions Sep 18, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Sep 18, 2020

Affected stories

  • 🌟 #174859517: Estendere il controllo della CTA valida

Generated by 🚫 dangerJS against b7d1a46

@CrisTofani CrisTofani marked this pull request as ready for review September 21, 2020 16:48
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2020

Codecov Report

Merging #2208 into master will decrease coverage by 0.04%.
The diff coverage is 44.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2208      +/-   ##
==========================================
- Coverage   47.24%   47.20%   -0.05%     
==========================================
  Files         503      502       -1     
  Lines       14934    14992      +58     
  Branches     3031     3046      +15     
==========================================
+ Hits         7056     7077      +21     
- Misses       7836     7873      +37     
  Partials       42       42              
Impacted Files Coverage Δ
ts/sagas/startup.ts 58.77% <0.00%> (+0.13%) ⬆️
ts/types/ServicesWebviewParams.ts 100.00% <ø> (ø)
ts/screens/services/ServicesWebviewScreen.tsx 35.00% <21.21%> (-6.47%) ⬇️
ts/components/messages/MessageNestedCTABar.tsx 35.29% <28.57%> (+1.96%) ⬆️
ts/components/ui/Markdown/handlers/internalLink.ts 76.19% <33.33%> (-1.86%) ⬇️
ts/screens/onboarding/PinScreen.tsx 20.16% <33.33%> (+0.34%) ⬆️
ts/components/messages/MessageDetailCTABar.tsx 30.76% <38.88%> (+2.56%) ⬆️
ts/components/messages/MessageListCTABar.tsx 31.25% <41.17%> (+1.83%) ⬆️
ts/screens/profile/ProfileMainScreen.tsx 29.28% <50.00%> (+0.20%) ⬆️
ts/sagas/identification.ts 32.65% <60.00%> (+0.04%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63b08ff...b7d1a46. Read the comment docs.

@CrisTofani CrisTofani marked this pull request as draft September 22, 2020 13:56
@CrisTofani CrisTofani marked this pull request as ready for review September 22, 2020 15:46
ts/components/messages/MessageDetailCTABar.tsx Outdated Show resolved Hide resolved
ts/utils/messages.ts Show resolved Hide resolved
@Undermaken Undermaken merged commit 3627ac9 into master Sep 25, 2020
@Undermaken Undermaken deleted the 174859517-cta-check-improvements branch September 25, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants