feat(Bonus Pagamenti Digitali): [#174816293,#174796530,#174794127] Display BDP in bonus list #2207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove check session as duplicated check moved bonus available request from bonus vacanze to content bonus available won't be displayed if it is hidden only hardoced bonus type can be handled
undo config
pagopa-github-bot
changed the title
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2207 +/- ##
=======================================
Coverage 47.17% 47.17%
=======================================
Files 492 491 -1
Lines 14763 14750 -13
Branches 3005 3004 -1
=======================================
- Hits 6964 6958 -6
+ Misses 7757 7750 -7
Partials 42 42
Continue to review full report at Codecov.
|
Undermaken
requested review from
CrisTofani,
fabriziofff and
francescopersico
as code owners
pagopa-github-bot
changed the title
…96530-bpd-available-bonus # Conflicts: # ts/features/bonus/bonusVacanze/api/backendBonusVacanze.ts # ts/features/bonus/bonusVacanze/screens/AvailableBonusScreen.tsx # ts/features/bonus/bonusVacanze/store/sagas/bonusSaga.ts # ts/features/bonus/bonusVacanze/store/sagas/handleLoadAvailableBonuses.ts # ts/screens/wallet/WalletHomeScreen.tsx
fabriziofff
approved these changes
Sep 18, 2020
Undermaken
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
To accomplish this task multiple changes were needed.
IO App
List of changes proposed in this pull request
checkSessioncheck outside of scoped saga (an optimization that doesn't refer this task)bdpis enabledIO services metadata
List of changes proposed in this pull request
hiddento BonusAvailable modelIO dev server PR#28
/sessionresponse (added token forbdpandmyportal)How to test
git pull;git checkout support-bpd;yarn generate:all;yarn startio-dev-server. Run this commandyarn generate:allbefore launching the app