feat(MyPortal): [#174801172] Screen component for region service external webview #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrisTofani
requested review from
fabriziofff,
francescopersico and
Undermaken
as code owners
pagopa-github-bot
changed the title
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2204 +/- ##
==========================================
+ Coverage 47.13% 47.15% +0.01%
==========================================
Files 492 493 +1
Lines 14790 14845 +55
Branches 2774 3017 +243
==========================================
+ Hits 6972 7000 +28
- Misses 7776 7803 +27
Partials 42 42
Continue to review full report at Codecov.
|
pagopa-github-bot
changed the title
Undermaken
suggested changes
Sep 21, 2020
|
|
||
| const initialInternalRouteNavigationState = null; | ||
| const initialInternalRouteNavigationState = { |
There was a problem hiding this comment.
Is this change needed?
an empty object could be misleading if we want to represent that there is no internal route
There was a problem hiding this comment.
Yep you're right, i currently reverted the change
|
|
||
| return { | ||
| url: maybeParams.fold("", p => p.url), | ||
| token: tokenFromSessionInfoSelector(state, "walletToken") |
There was a problem hiding this comment.
Suggested change
| token: tokenFromSessionInfoSelector(state, "walletToken") | |
| token: tokenFromNameSelector("walletToken")(state) |
see other suggestion about selector
| const [isCookieAvailable, setIsCookieAvailable] = React.useState(false); | ||
| const [cookieError, setCookieError] = React.useState(false); | ||
|
|
||
| const onDidFocus = () => { |
There was a problem hiding this comment.
I did few test and this callback is never called (maybe a bug on navigation library)
Perhaps you could use React.useEffect with a clean-up callback. I tested it and it works
ts/store/reducers/authentication.ts
Outdated
| @@ -132,6 +136,17 @@ export const sessionInfoSelector = (state: GlobalState) => | |||
| ? some(state.authentication.sessionInfo) | |||
| : none; | |||
|
|
|||
| export const tokenFromSessionInfoSelector = ( | |||
There was a problem hiding this comment.
Suggested change
| export const tokenFromSessionInfoSelector = ( | |
| export const tokenFromNameSelector = ( | |
| tokenName: keyof Omit<PublicSession, "spidLevel"> | |
| ): ((state: GlobalState) => Option<string>) => | |
| createSelector<GlobalState, Option<PublicSession>, Option<string>>( | |
| sessionInfoSelector, | |
| maybeSessionInfo => maybeSessionInfo.map(si => si[tokenName]) | |
| ); |
…pagopa/io-app into 174801172-region-service-webview-screen
Undermaken
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the screen component for rendering the external webview of a service
How to test
Set the MYPORTAL_ENABLED env variable to true and navigate to the screen from a custom CTA component from dev-server, with action value set to:
ioit://SERVICE_WEBVIEW&?url=http://localhost:3000/myportal_playground.html