-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [#174596045] Change api call from getProfile to getSession #2201
Conversation
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2201 +/- ##
==========================================
+ Coverage 47.15% 47.17% +0.01%
==========================================
Files 493 492 -1
Lines 14844 14762 -82
Branches 2779 2767 -12
==========================================
- Hits 7000 6964 -36
+ Misses 7802 7756 -46
Partials 42 42
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't understand very well this approach.
In my mind this is should be something like this:
- we use
getProfile
to check whenever the session is still valid - now we change
getProfile
withgetSession
(because we use composition inwatchCheckSessionSaga
) - different from before if the session is successfully loaded, dispatch the
sessionInformationLoadSuccess
action (to update the store) - add another iteration in the relative test (different from before we dispatch a new action in the OK path)
here my attempt 93d5091
In your code you added another task to loadSessionInformationSaga
function: now it is responsible to load the session and to dispatch an action about the check session
Short description
This PR replaces the getProfile with getSession on checkSessionSaga