-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [#173639055] Display all cc in wallet section #2196
feat: [#173639055] Display all cc in wallet section #2196
Conversation
Affected stories
|
Codecov Report
@@ Coverage Diff @@
## master #2196 +/- ##
==========================================
- Coverage 47.17% 47.17% -0.01%
==========================================
Files 492 492
Lines 14753 14761 +8
Branches 3009 3005 -4
==========================================
+ Hits 6960 6963 +3
- Misses 7751 7756 +5
Partials 42 42
Continue to review full report at Codecov.
|
return fromNullable(wallet).fold(undefined, w => ( | ||
<> | ||
<TouchableDefaultOpacity | ||
key={`wallet_${w.idWallet}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the key on a child node of a repeated component raises the current warning:
this solution should solve this warning:
<React.Fragment key={`wallet_${w.idWallet}`}>
<TouchableDefaultOpacity
onPress={() => onClick(w)}
accessible={true}
accessibilityLabel={I18n.t("wallet.accessibility.cardsPreview")}
accessibilityRole={"button"}
>
{Platform.OS === "android" && <View style={styles.shadowBox} />}
<View style={styles.rotatedCard}>
<CardComponent type={"Preview"} wallet={w} />
</View>
</TouchableDefaultOpacity>
{!isLastItem && <View spacer={true} />}
</React.Fragment>
…om:pagopa/io-app into 173639055-display-all-cc-in-wallet-section
Short description
This PR shows all credit card owned by the user and not maximum of two
Now then a credit card is tapped the app shows the card details instead of wallets list