Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [#173639055] Display all cc in wallet section #2196

Merged
merged 11 commits into from
Sep 15, 2020

Conversation

Undermaken
Copy link
Contributor

@Undermaken Undermaken commented Sep 14, 2020

Short description

This PR shows all credit card owned by the user and not maximum of two
Now then a credit card is tapped the app shows the card details instead of wallets list

before before
before before

@pagopa-github-bot pagopa-github-bot changed the title [#173639055] Display all cc in wallet section feat: [#173639055] Display all cc in wallet section Sep 14, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Sep 14, 2020

Affected stories

  • 🌟 #173639055: Come CIT sulla home dei pagamenti voglio vedere tutte le carte disponibili e non solo le prime due

Generated by 🚫 dangerJS against 0fba152

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2020

Codecov Report

Merging #2196 into master will decrease coverage by 0.00%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2196      +/-   ##
==========================================
- Coverage   47.17%   47.17%   -0.01%     
==========================================
  Files         492      492              
  Lines       14753    14761       +8     
  Branches     3009     3005       -4     
==========================================
+ Hits         6960     6963       +3     
- Misses       7751     7756       +5     
  Partials       42       42              
Impacted Files Coverage Δ
ts/screens/wallet/WalletHomeScreen.tsx 26.66% <0.00%> (-0.17%) ⬇️
ts/components/wallet/card/RotatedCards.tsx 45.16% <21.42%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba9513a...0fba152. Read the comment docs.

@Undermaken Undermaken marked this pull request as ready for review September 14, 2020 17:12
return fromNullable(wallet).fold(undefined, w => (
<>
<TouchableDefaultOpacity
key={`wallet_${w.idWallet}`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the key on a child node of a repeated component raises the current warning:

this solution should solve this warning:

      <React.Fragment key={`wallet_${w.idWallet}`}>
        <TouchableDefaultOpacity
          onPress={() => onClick(w)}
          accessible={true}
          accessibilityLabel={I18n.t("wallet.accessibility.cardsPreview")}
          accessibilityRole={"button"}
        >
          {Platform.OS === "android" && <View style={styles.shadowBox} />}
          <View style={styles.rotatedCard}>
            <CardComponent type={"Preview"} wallet={w} />
          </View>
        </TouchableDefaultOpacity>
        {!isLastItem && <View spacer={true} />}
      </React.Fragment>

@CrisTofani CrisTofani merged commit c7e5e66 into master Sep 15, 2020
@CrisTofani CrisTofani deleted the 173639055-display-all-cc-in-wallet-section branch March 23, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants