Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [#174712071] Update and sync preferred language #2186

Merged
merged 9 commits into from
Sep 9, 2020

Conversation

Undermaken
Copy link
Contributor

@Undermaken Undermaken commented Sep 8, 2020

⚠️ THIS PR DEPENDS on #2184

Short description

This PR does some stuffs about language

  1. check if the loaded profile has a preferred language
  2. if the profile has not a preferred_language it will be updated with the language stored in the store or with the device language if any value is in the store
  3. sync the store with the value set in the profile

To do the above steps, this PR introduces a watcher on load profile: when the profile is successfully loaded then a saga will be executed

@pagopa-github-bot pagopa-github-bot changed the title [#174712071] Update and sync preferred language feat: [#174712071] Update and sync preferred language Sep 8, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Sep 8, 2020

Affected stories

  • 🌟 #174712071: Controllare che il profilo abbia una lingua preferita impostata

Generated by 🚫 dangerJS against 5d78e47

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2020

Codecov Report

Merging #2186 into master will decrease coverage by 0.01%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2186      +/-   ##
==========================================
- Coverage   47.03%   47.01%   -0.02%     
==========================================
  Files         485      485              
  Lines       14554    14574      +20     
  Branches     2981     2988       +7     
==========================================
+ Hits         6845     6852       +7     
- Misses       7667     7680      +13     
  Partials       42       42              
Impacted Files Coverage Δ
ts/sagas/profile.ts 28.33% <21.05%> (-6.56%) ⬇️
ts/sagas/startup.ts 58.77% <100.00%> (+1.52%) ⬆️
ts/utils/locale.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a22f330...5d78e47. Read the comment docs.

@Undermaken Undermaken marked this pull request as ready for review September 8, 2020 16:52
@CrisTofani CrisTofani merged commit 7fa533f into master Sep 9, 2020
@CrisTofani CrisTofani deleted the 174712071-update-current-locale branch March 23, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants