Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [#173190756] Update profile on language selection #2184

Merged
merged 3 commits into from
Sep 9, 2020

Conversation

Undermaken
Copy link
Contributor

Short description

This PR update the user's profile when he/she selects the language which he wants use.

this is the flow how looks like now:

  • pick a language
  • update the profile and show loading
  • check when the update finishes
  • if update went well show a modal to inform the app should be restarted
  • if update went wrong show a toast with an error message

@pagopa-github-bot pagopa-github-bot changed the title [#173190756] Update profile on language selection feat: [#173190756] Update profile on language selection Sep 8, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Sep 8, 2020

Affected stories

  • 🌟 #173190756: Quando il CIT cambia la preferenza della lingua bisogna aggiornare il profilo

Generated by 🚫 dangerJS against 1e5b68b

@codecov-commenter
Copy link

Codecov Report

Merging #2184 into master will decrease coverage by 0.01%.
The diff coverage is 35.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2184      +/-   ##
==========================================
- Coverage   47.04%   47.03%   -0.02%     
==========================================
  Files         485      485              
  Lines       14530    14554      +24     
  Branches     2978     2979       +1     
==========================================
+ Hits         6836     6845       +9     
- Misses       7652     7667      +15     
  Partials       42       42              
Impacted Files Coverage Δ
ts/store/actions/profile.ts 100.00% <ø> (ø)
ts/screens/profile/LanguagesPreferencesScreen.tsx 39.34% <25.92%> (-5.66%) ⬇️
ts/utils/locale.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82d63ec...1e5b68b. Read the comment docs.

@CrisTofani CrisTofani merged commit a22f330 into master Sep 9, 2020
@fabriziofff fabriziofff deleted the 173190756-update-profile-language branch January 21, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants