Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Payments): [#174552971] Notice number is wrong composed #2180

Merged
merged 3 commits into from
Sep 7, 2020

Conversation

Undermaken
Copy link
Contributor

@Undermaken Undermaken commented Sep 4, 2020

Short description

This PR changes few points about payments:

  1. fix notice code composition (specifically aux 3 case)
  2. leave all other text following the causale extracted from transaction description
  3. add and dispatch a dedicated action when a new credit card is added to the user wallet

dispatch a dedicated action when a credit card is successfully added
fix numero avviso building
add tests
@pagopa-github-bot pagopa-github-bot changed the title [#174552971] Notice code is wrong composed fix: [#174552971] Notice code is wrong composed Sep 4, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Sep 4, 2020

Affected stories

  • 🐞 #174552971: [minor] il codice avviso riportato nel dettaglio di un pagamento problematico è costruito in maniera errata

Generated by 🚫 dangerJS against 8fd4106

@pagopa-github-bot pagopa-github-bot changed the title fix: [#174552971] Notice code is wrong composed fix(Payments): [#174552971] Notice code is wrong composed Sep 4, 2020
@Undermaken Undermaken marked this pull request as ready for review September 4, 2020 15:58
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2020

Codecov Report

Merging #2180 into master will increase coverage by 0.13%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2180      +/-   ##
==========================================
+ Coverage   46.99%   47.13%   +0.13%     
==========================================
  Files         484      484              
  Lines       14461    14459       -2     
  Branches     2728     2726       -2     
==========================================
+ Hits         6796     6815      +19     
+ Misses       7623     7602      -21     
  Partials       42       42              
Impacted Files Coverage Δ
ts/sagas/wallet.ts 18.24% <0.00%> (-0.13%) ⬇️
ts/screens/wallet/PaymentHistoryDetailsScreen.tsx 35.29% <ø> (ø)
ts/store/reducers/payments/history.ts 89.47% <ø> (+24.04%) ⬆️
ts/components/wallet/PaymentsHistoryList.tsx 43.58% <100.00%> (+1.48%) ⬆️
ts/store/actions/wallet/wallets.ts 100.00% <100.00%> (ø)
ts/utils/payment.ts 59.64% <100.00%> (+8.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 183d5a0...8fd4106. Read the comment docs.

@Undermaken Undermaken changed the title fix(Payments): [#174552971] Notice code is wrong composed fix(Payments): [#174552971] Notice number is wrong composed Sep 4, 2020
@CrisTofani CrisTofani merged commit 607c29f into master Sep 7, 2020
@fabriziofff fabriziofff deleted the 174552971-fix-iuv-building branch January 21, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants