Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#174160259] Switch label to change text on switch value change #2168

Merged
merged 4 commits into from
Aug 31, 2020

Conversation

CrisTofani
Copy link
Contributor

Short description:
This PR fixes the dynamic change for service enable/disable switch label.

@pagopa-github-bot pagopa-github-bot changed the title [#174160259] Switch label to change text on switch value change fix: [#174160259] Switch label to change text on switch value change Aug 25, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Aug 25, 2020

Affected stories

  • 🐞 #174160259: [major] Lo stato degli switches nel dettaglio del servizio non è coerente

Generated by 🚫 dangerJS against 31a63e1

@CrisTofani CrisTofani marked this pull request as draft August 25, 2020 16:05
@CrisTofani CrisTofani marked this pull request as ready for review August 26, 2020 16:02
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2020

Codecov Report

Merging #2168 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2168      +/-   ##
==========================================
- Coverage   46.59%   46.59%   -0.01%     
==========================================
  Files         484      484              
  Lines       14689    14690       +1     
  Branches     2755     2756       +1     
==========================================
  Hits         6845     6845              
- Misses       7802     7803       +1     
  Partials       42       42              
Impacted Files Coverage Δ
ts/screens/services/ServiceDetailsScreen.tsx 22.84% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d6ae4...31a63e1. Read the comment docs.

fix a bug that computes profile status only when the screen is mounted
@Undermaken Undermaken merged commit 78110e5 into master Aug 31, 2020
@CrisTofani CrisTofani deleted the 174160259-fixes-switch-label branch March 23, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants