Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [#174034065] Add info about session expiration #2142

Merged
merged 5 commits into from
Aug 10, 2020

Conversation

Undermaken
Copy link
Contributor

Short description:
This PR add an info box describing what happen when session expires in Spid and CIE login screens

CIE SPID
CIE SPID

@pagopa-github-bot pagopa-github-bot changed the title [#174034065] Add info about session expiration feat: [#174034065] Add info about session expiration Aug 10, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Aug 10, 2020

Affected stories

  • 🌟 #174034065: Come CIT voglio essere informato del fatto che la mia login con SPID o CIE è scaduta dopo 30gg.

Generated by 🚫 dangerJS against bfd5437

@codecov-commenter
Copy link

Codecov Report

Merging #2142 into master will decrease coverage by 0.00%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2142      +/-   ##
==========================================
- Coverage   44.85%   44.85%   -0.01%     
==========================================
  Files         466      466              
  Lines       14341    14344       +3     
  Branches     2910     2698     -212     
==========================================
+ Hits         6433     6434       +1     
- Misses       7865     7867       +2     
  Partials       43       43              
Impacted Files Coverage Δ
ts/components/AdviceComponent.tsx 75.00% <50.00%> (ø)
ts/components/InstabugAssistanceComponent.tsx 63.63% <100.00%> (ø)
ts/screens/authentication/IdpSelectionScreen.tsx 52.50% <100.00%> (+1.21%) ⬆️
ts/screens/authentication/cie/CiePinScreen.tsx 41.17% <100.00%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63fa72f...bfd5437. Read the comment docs.

@Undermaken Undermaken requested a review from fabriziofff August 10, 2020 12:42
@Undermaken Undermaken marked this pull request as ready for review August 10, 2020 12:43
@fabriziofff fabriziofff merged commit f93f804 into master Aug 10, 2020
@fabriziofff fabriziofff deleted the 174034065-info-about-session-expiration branch August 10, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants