Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#174186215] Wrong checkbox rendering in IngressScreen #2135

Merged

Conversation

fabriziofff
Copy link
Contributor

Short description:
This pr fixes the wrong checkbox rendering in InfoScreen.

iOS Android

List of changes proposed in this pull request:

  • Added a custom component to fix the wrong behaviour of native-base Checkbox.

@pagopa-github-bot
Copy link
Collaborator

Affected stories

  • 🐞 #174186215: [trivial] Le check box nella IngressScreen non sono renderizzate correttamente

Generated by 🚫 dangerJS

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2020

Codecov Report

Merging #2135 into master will increase coverage by 0.01%.
The diff coverage is 73.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2135      +/-   ##
==========================================
+ Coverage   44.86%   44.88%   +0.01%     
==========================================
  Files         465      466       +1     
  Lines       14276    14292      +16     
  Branches     2897     2901       +4     
==========================================
+ Hits         6405     6415      +10     
- Misses       7828     7834       +6     
  Partials       43       43              
Impacted Files Coverage Δ
ts/screens/ingress/CheckBox.tsx 60.00% <60.00%> (ø)
ts/navigation/AppNavigator.ts 83.33% <100.00%> (ø)
ts/screens/ingress/IngressScreen.tsx 50.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd43abe...1ecaece. Read the comment docs.

@Undermaken Undermaken merged commit b0ea88d into master Aug 7, 2020
@Undermaken Undermaken deleted the 174186215-wrong-checkbox-rendering-ingress-screen branch August 7, 2020 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants