Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#174179069] Pin insertion overflow #2127

Merged
merged 2 commits into from
Aug 6, 2020

Conversation

Undermaken
Copy link
Contributor

@Undermaken Undermaken commented Aug 4, 2020

Short description:
Fix the app pin insertion overflow

How to reproduce the bug:

  • insert the pin (1st time) 333333
  • insert the same pin of the 1st time but adding 2 digits more 33333344
  • the continue button is displayed (ok, that's right)
  • press del delete button: continue button disappears but the pin seems full filled (bug)

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Aug 4, 2020

Affected stories

  • 🐞 #174179069: [minor] Inserendo la ripetizione del PIN dell'app oltre la lunghezza si entra in uno stato inconsistente

Generated by 🚫 dangerJS

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2020

Codecov Report

Merging #2127 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #2127    +/-   ##
========================================
  Coverage   44.86%   44.86%            
========================================
  Files         465      465            
  Lines       14259    14259            
  Branches     2683     2894   +211     
========================================
  Hits         6398     6398            
  Misses       7818     7818            
  Partials       43       43            
Impacted Files Coverage Δ
ts/components/Pinpad/index.tsx 20.83% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a0d659...0e6ba4c. Read the comment docs.

@CrisTofani CrisTofani merged commit c3fc106 into master Aug 6, 2020
@fabriziofff fabriziofff deleted the 174179069-fix-pin-rep-insertion branch January 21, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants