Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#174119099] Display app version #2122

Merged
merged 6 commits into from
Jul 31, 2020
Merged

Conversation

Undermaken
Copy link
Contributor

Short description:
This PR fixes a wrong representation of app version in Android OS
1.4.0.2 is displayed as 1.4.0.2.3 (3 is the build number)

This fix includes:

  • ios family: version within the build number
  • andorid family: version without the build number

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jul 31, 2020

Affected stories

  • 🐞 #174119099: [minor] Le versioni di Android e iOS non vengono rappresentate allo stesso modo

Generated by 🚫 dangerJS

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2020

Codecov Report

Merging #2122 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2122   +/-   ##
=======================================
  Coverage   45.50%   45.50%           
=======================================
  Files         464      464           
  Lines       13997    13997           
  Branches     2893     2893           
=======================================
  Hits         6369     6369           
  Misses       7584     7584           
  Partials       44       44           
Impacted Files Coverage Δ
ts/utils/appVersion.ts 89.28% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3dcb7b...c38dda4. Read the comment docs.

@CrisTofani CrisTofani merged commit 4dd9763 into master Jul 31, 2020
@CrisTofani CrisTofani deleted the 174119099-fix-app-version branch March 23, 2021 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants