Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Don't use the arrows if there's no submenu. #2117

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

bfabio
Copy link
Contributor

@bfabio bfabio commented Jul 30, 2020

Remove the arrows in ListComponents if the item leads to an immediate
action (ie. there's no submenu).

Before After
before after

Copy link
Contributor

@CrisTofani CrisTofani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We worked on the same fix few hours ago 😄 #2116

@CrisTofani
Copy link
Contributor

We worked on the same fix few hours ago 😄 #2116

@bfabio Just noticed that you fixed another menu item too! Good catch!

@bfabio
Copy link
Contributor Author

bfabio commented Jul 30, 2020

We worked on the same fix few hours ago smile #2116

@CrisTofani Oh man, LOL, what are the odds 😄

Remove the arrows in ListComponents if the item leads to an immediate
action (ie. there's no submenu).
@bfabio bfabio changed the title fix(ui): Don't use the arrows there's no submenu. fix(ui): Don't use the arrows if there's no submenu. Jul 30, 2020
@Undermaken Undermaken merged commit 0ecd486 into pagopa:master Jul 30, 2020
@bfabio bfabio deleted the menus branch February 20, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants