[#174085364] messagesStatus store section cleaning #2114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handle remove message in reducer add tests
Affected stories
Generated by 🚫 dangerJS |
Undermaken
changed the title
Undermaken
changed the title
Undermaken
requested review from
CrisTofani,
fabriziofff and
francescopersico
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2114 +/- ##
==========================================
+ Coverage 45.50% 45.65% +0.15%
==========================================
Files 464 464
Lines 13997 14008 +11
Branches 2893 2893
==========================================
+ Hits 6369 6396 +27
+ Misses 7584 7569 -15
+ Partials 44 43 -1
Continue to review full report at Codecov.
|
CrisTofani
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description:
This PR adds a little improvement on messagesStatus store section
By adding the handling of
removeMessagesaction, the reducer can clean all entries that are no longer needed: i.e when the messagesStatus store contains a messageId (one or more) that is not present in the loaded messages (different user or message delete)Starting from the cleaning, the messagesStatus won't be deleted on logout (explicit or implicit (session expired))