-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#173890674] Refactoring props for accessibility events on base header #2087
Conversation
Affected stories
Generated by 🚫 dangerJS |
ts/components/screens/BaseHeader.tsx
Outdated
{fromNullable(this.props.accessibilityEvents).fold( | ||
true, | ||
({ avoidNavigationEventsUsage, disableAccessibilityFocus }) => | ||
!(avoidNavigationEventsUsage && disableAccessibilityFocus) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this condition causes a crash:
- avoidNavigationEventsUsage = true , disableAccessibilityFocus = false -> true (error)
fix and refactor 1068bdf
Codecov Report
@@ Coverage Diff @@
## master #2087 +/- ##
==========================================
- Coverage 45.53% 45.51% -0.03%
==========================================
Files 464 464
Lines 13975 13984 +9
Branches 2676 2888 +212
==========================================
+ Hits 6364 6365 +1
- Misses 7567 7575 +8
Partials 44 44
Continue to review full report at Codecov.
|
…s-on-header-prop # Conflicts: # ts/screens/modal/UpdateAppModal.tsx
Short description:
This PR adds a prop on base header to avoid the accessibility focus on chosen screens
the new prop is defined as a new object type: