Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#173829043] Improve Reactotron usage #2056

Merged
merged 3 commits into from
Jul 17, 2020
Merged

[#173829043] Improve Reactotron usage #2056

merged 3 commits into from
Jul 17, 2020

Conversation

Undermaken
Copy link
Contributor

@Undermaken Undermaken commented Jul 16, 2020 •
edited
Loading

Short description:

  • update Reactotron libs
  • fix types and check on reactotron instance creation
  • export typed log methods

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jul 16, 2020 •
edited
Loading

Affected stories

  • 🐞 #173829043: Migliorare l'uso dei log di Reactotron

Generated by 🚫 dangerJS

@Undermaken Undermaken marked this pull request as ready for review July 16, 2020 09:47
fabriziofff
fabriziofff suggested changes Jul 17, 2020
View reviewed changes
ts/boot/configureStoreAndPersistor.ts Outdated
@@ -283,9 +283,18 @@ const logger = createLogger({
});

// configure Reactotron if the app is running in dev mode
export const RTron = isDevEnv ? configureReactotron() : {};
const RTron = isDevEnv ? configureReactotron() : undefined;
Copy link
Contributor

@fabriziofff fabriziofff Jul 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be a good idea to still export the RTron instance in order to access to the other features.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure done in 18b8d27

@Undermaken Undermaken requested a review from fabriziofff July 17, 2020 11:00
@Undermaken Undermaken merged commit 9a22ccd into master Jul 17, 2020
@fabriziofff fabriziofff deleted the 173829043-improve-reactotron-usage branch January 21, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziofff fabriziofff fabriziofff approved these changes

@CrisTofani CrisTofani Awaiting requested review from CrisTofani

@francescopersico francescopersico Awaiting requested review from francescopersico

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Undermaken @pagopa-github-bot @fabriziofff