[#173769898] fix accessibility for loadingerrorcomponent #2043
Conversation
…nt' into 173769898-fix-accessibility-for-loadingerrorcomponent
…sibility-for-loadingerrorcomponent
fabriziofff
requested review from
francescopersico and
Undermaken
as code owners
Affected stories
Generated by 🚫 dangerJS |
| useEffect( | ||
| () => { | ||
| if (props.isLoading) { | ||
| setAccessibilityFocus(loadingRef, delay); |
There was a problem hiding this comment.
| setAccessibilityFocus(loadingRef, delay); | |
| setAccessibilityFocus(lprops.isLoading ? loadingRef : errorRef, delay); |
same but more coincise
There was a problem hiding this comment.
changed in e677b09
| <View accessible={true} ref={loadingRef} style={{ flex: 1 }}> | ||
| <InfoScreenComponent | ||
| image={ | ||
| <Spinner |
There was a problem hiding this comment.
| <Spinner | |
| <ActivityIndicator color={themeVariables.brandPrimaryLight} /> |
you could use ActivityIndicator since it is already used in few parts (/components/ui/ActivityIndicator)
| Spinner black | ActivityIndicator |
|---|---|
 |
 |
Furthermore we could keep the InfoScreenComponent title as non-bold text as it was previously
current on master
There was a problem hiding this comment.
LoadingSpinner changed in e677b09
The text is changed to bold in order to use this pr as an occasion to implements the graphical requirement that was never implemented https://pagopa.invisionapp.com/console/Bonus-Vacanze-ckas11mrt0cfe016bekk47kk5/ckb19iapa0036013eyble6agi/play
Just the subtext cannot be normal for accessibility reasons.
fabriziofff
deleted the
173769898-fix-accessibility-for-loadingerrorcomponent
branch
Short description:
This pr fix and improves the accessibility for the
LoadingErrorComponentList of changes proposed in this pull request: