Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#173701927] Improve accessibility for top bar #2020

Merged
merged 4 commits into from
Jul 9, 2020
Merged

[#173701927] Improve accessibility for top bar #2020

merged 4 commits into from
Jul 9, 2020

Conversation

fabriziofff
Copy link
Contributor

@fabriziofff fabriziofff commented Jul 8, 2020 •
edited
Loading

Short description:
This pr improves the accesibility with a vocal assistant for the top bar.

List of changes proposed in this pull request:

  • The buttons "back", "search", "help" and "instabug chat" are now identified as buttons (ios, android)
  • When the voice assistante focus the "instabug chat" icon, announces also the number of unread messages.
  • TheheaderTitle is now recognized as "header" (ios only)

@fabriziofff fabriziofff added the a11y Activities related to accessibility label Jul 8, 2020
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Jul 8, 2020 •
edited
Loading

Affected stories

  • 🐞 #173701927: [ios] Top bar icons (messaggi, help, ricerca) non vengono rilevati come bottoni tramite cui è possibile intraprendere azioni

Generated by 🚫 dangerJS

@Undermaken Undermaken merged commit a208dd5 into master Jul 9, 2020
@fabriziofff fabriziofff deleted the 173701927-accessibility-top-bar-buttons branch January 21, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CrisTofani CrisTofani CrisTofani approved these changes

@Undermaken Undermaken Undermaken approved these changes

@francescopersico francescopersico Awaiting requested review from francescopersico

@matteodesanti matteodesanti Awaiting requested review from matteodesanti

Assignees
No one assigned
Labels
a11y Activities related to accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabriziofff @pagopa-github-bot @Undermaken @CrisTofani