[#173521040] Update elgibility expired screen & eligibility / activation navigation rework #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziofff
requested review from
francescopersico,
matteodesanti and
Undermaken
as code owners
Affected stories
Generated by 🚫 dangerJS |
…gibility-expired-screen
…gibility-expired-screen
…gibility-expired-screen
…gibility-expired-screen
Undermaken
reviewed
Jul 14, 2020
img/pictograms/hourglass.svg
Outdated
| @@ -0,0 +1,20 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
@CrisTofani we need you help: could it be possible to include this svg in our icon-pack?
There was a problem hiding this comment.
@fabriziofff Since the png is used, is this svg needed?
There was a problem hiding this comment.
Due to legacy configuration of react-native-typescript-transformer the svg file could not be imported (https://github.com/kristerkari/react-native-svg-transformer#installation-and-configuration) and was replaced by a png.
removed in e5af8d5
Undermaken
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description:
This pr updates the eligibility expired screen and refactor the navigation for the eligibility and activation phase.
List of changes proposed in this pull request:
EligibilityExpired.tsxEligibilityExpired.tsxin order to restart the eligibility phase.navigationPopwhen callingcheckBonusVacanzeEligibility.request()NavigationActions.back()when canceled or closed the eligibility / activation workflow.BonusAlreadyExistsbutton ->onGoToBonus-> goto walletHome.