[#173510346] Fixes test 2e2 #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affected stories
Generated by 🚫 dangerJS |
CrisTofani
approved these changes
Jun 26, 2020
fabriziofff
reviewed
Jun 26, 2020
Comment on lines
+51
to
+52
| case BonusActivationStatusEnum.PROCESSING: | ||
| return left(none); |
There was a problem hiding this comment.
In this case the user will see the generic error page (cancel / retry). Is it right when in processing?
There was a problem hiding this comment.
@fabriziofff
The comment is misleading. In that case we should continue to polling.
Do you confirm?
update within bd8a090
There was a problem hiding this comment.
if (
bonusActivationFromIdResult.isLeft() &&
bonusActivationFromIdResult.value.isSome()
) {
throw bonusActivationFromIdResult.value;
}If I understand right when getBonusActivation return any left value, the polling is stopped and a activateBonusVacanze.failure(e) is dispatched. So all the switch cases will stop the polling. It is right?
EDIT: nvm, left(none) will continue the polling, I understand now!
fabriziofff
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description:
Fixes test 2e2