[#173171577] Extract front-matter CTA data from message content

[Undermaken]

Short description:
This PR extracts cta data from message content (front-matter)

• add front-matter lib to parse data
• add some utils function to:
  • extract ctas from message content
  • validate cta action
  • remove front matter from message content
• add cta type defintion
• add tests

[pagopa-github-bot]

Affected stories

• 🌟 #173171577: Il markdown nel messaggio contiene un front-matter che permette di specificare 2 CTA

New dependencies added: front-matter.

front-matter

Author: Jason Campbell

Description: Extract YAML front matter from a string

Homepage: https://github.com/jxson/front-matter

Created	almost 8 years ago
Last Updated	25 days ago
License	MIT
Maintainers	1
Releases	37
Direct Dependencies	js-yaml
Keywords	yaml, front matter and meta data

README

front-matter

Extract meta data (front-matter) from documents.

This modules does not do any IO (file loading or reading), only extracting and
parsing front matter from strings.

This concept that was originally introduced to me through the jekyll blogging system and is pretty useful where you want to be able to easily add meta-data to content without the need for a database. YAML is extracted from the the top of a file between matching separators of "---" or "= yaml =". It will also extract YAML between a separator and "...".

Install

With npm do:

npm install front-matter

Example

So you have a file example.md:

---
title: Just hack'n
description: Nothing to see here
---

This is some text about some stuff that happened sometime ago

NOTE: As of [email protected] valid front matter is considered to have
the starting separator on the first line.

Then you can do this:

var fs = require('fs')
  , fm = require('front-matter')

fs.readFile('./example.md', 'utf8', function(err, data){
  if (err) throw err

  var content = fm(data)

  console.log(content)
})

And end up with an object like this:

{
    attributes: {
        title: 'Just hack\'n',
        description: 'Nothing to see here'
    },
    body: 'This is some text about some stuff that happened sometime ago',
    bodyBegin: 6,
    frontmatter: 'title: Just hack\'n\ndescription: Nothing to see here'
}

Methods

var fm = require('front-matter')

fm(string, { allowUnsafe: false })

Return a content object with two properties:

• content.attributes contains the extracted yaml attributes in json form
• content.body contains the string contents below the yaml separators
• content.bodyBegin contains the line number the body contents begins at
• content.frontmatter contains the original yaml string contents

NOTE: By default fm() uses ys-yaml's safeLoad unless you set
allowUnsafe in the options object to true.

fm.test(string)

Check if a string contains a front matter header of "---" or "= yaml =". Primarily used internally but is useful outside of the module.

Returns true or false

    fm.test(string) #=> true || false

Contributing

front-matter is an OPEN Source Project so please help out by reporting bugs or forking and opening pull requests when possible.

All code is linted/formatted using standard style, any non-conforming code can be automatically formatted using the the fmt make task: make fmt.

Maintainers

• Adrian Gimenez
• Jason Campbell - @jxson

Contributors

This module is awesome because of all the folks who submitted pull requests:

• Jordan Santell - @jsantell
• Jean-Philippe Monette - @jpmonette
• Kai Davenport
• Marc-André Arseneault - @im_arsnl
• Bret Comnes - http://bret.io
• Shinnosuke Watanabe
• Matt Dickens
• Rod Knowlton
• Rich DeLauder
• Sean Lang - http://slang.cx
• Benjamin Tan - https://d10.github.io/
• Kenneth Lim - https://kenlimmj.com
• Cameron Moy
• Fernando Montoya - https://montogeek.com
• Martin Heidegger
• Leo Liang
• Kasper Pedersen

CHANGELOG

3.0.0

• CI only tests Node versions >= v6 (drops v4, and v5)

LICENSE (MIT)

Copyright (c) Jason Campbell ("Author")

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

Generated by 🚫 dangerJS

[CrisTofani]

In case we are working on a locale that is missing from the CTA we received in the message we return a none and we won't show the cta even if it has been added to the message.

E.g. User changed to "EN" from preferences option in the message we received just the CTA on IT language -> no CTA displayed. Should we fallback on the received CTA?

[Undermaken]

@CrisTofani
Yes it could happen.
What if we make it/en as required and not optional?

[CrisTofani]

@Undermaken
I think it could fail anyway cause we don't have the complete control of what we get since it is a remote content, maybe we should handle attrs as an array of string and fallback on the first we get?

[Undermaken]

@CrisTofani
starting from your warning I improved the logic and I added a test ae77f58:
now if the front-matter doesn't respect MessageCTA type the decoding will fail.
So if, from remote, we receive a data that doesn't contain it nor en the CTA won't be decoded.

Btw about the fallback we can do as follow: since at the moment the MessageCTA requires it/en, if the CTA for the current locale is not available we can fallback to the other one. if from remote we receive not it/en, fr for example, the decoding will fail

What do you think?

[CrisTofani]

Yep! I find it is a good point!

[Undermaken]

update within 0dd7a0f