[#173353526] Fix transaction details crash #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affected stories
Generated by 🚫 dangerJS |
CrisTofani
requested changes
Jun 16, 2020
ts/utils/strings.ts
Outdated
| * @param text | ||
| */ | ||
| export const isNullyOrEmpty = (text: string | undefined | null) => { | ||
| return (text || "").trim().length === 0; |
There was a problem hiding this comment.
why don't to use fromNullable ?
something like:
fromNullable(text).fold(false, t => t.trim().length===0)Just a suggestion, I think your solution works fine too!
There was a problem hiding this comment.
It is definitely better
Update here b2647ce
CrisTofani
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description:
This PR fixes a bug on transaction details.
Due to a wrong statement the app try to render an empty text
Buggy code
stringValue && <SomeComponent>fails whenstringValue===""this is because:
undefined && <SomeComponent>->undefined"some text" && <SomeComponent>-><SomeComponent>"" && <SomeComponent>->""It goes fine only when stringValue is not undefined and with length > 0