[#173147132] Send chunked log to instabug #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Affected stories
Generated by 🚫 dangerJS |
Undermaken
suggested changes
Jun 4, 2020
ts/boot/configureInstabug.ts
Outdated
| if (chunks) { | ||
| chunks.forEach((chunk, i) => { | ||
| const count = chunks.length > 1 ? ` ${i + 1}/${chunks.length}` : ""; | ||
| InstabugLogger[typeLog](`[${tag}${count}] ${chunk}`); |
There was a problem hiding this comment.
tag could be undefined
Suggested change
| InstabugLogger[typeLog](`[${tag}${count}] ${chunk}`); | |
| const tagPrefix = fromNullable(tag).fold("", t => `${t} `); | |
| const prefix = | |
| chunks.length > 1 ? `[${tagPrefix}${i + 1}/${chunks.length}] ` : ""; | |
| return `${prefix}${chunk}`; | |
| InstabugLogger[typeLog](`[${tag}${count}] ${chunk}`); |
tagPrefix could be computed just one time and placed outside of the forEach
There was a problem hiding this comment.
Changed in 8909a96
Undermaken
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description:
This pr allows to send log to instabug divided into maximum chunks of 4096 characters.
List of changes proposed in this pull request:
instabugLogChunked.