-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#173102302] Load activate bonus #1865
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bonus-eligibility-workflow
…bonus-eligibility-workflow
… into 172992652-activate-bonus-screen
…bonus-eligibility-workflow
…nus-eligibility-workflow
…com:pagopa/io-app into 173054348-verify-bonus-eligibility-workflow
fabriziofff
requested review from
francescopersico,
matteodesanti and
Undermaken
as code owners
June 1, 2020 10:56
Affected stories
Generated by 🚫 dangerJS |
Undermaken
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr depends on (#1864)
Short description:
This pr adds the Screen for the "Activate bonus" and the associated loading / error handling phase.
List of changes proposed in this pull request:
ts/features/bonusVacanze/screens/eligibility/ActivateBonus/LoadActivateBonusScreen.tsx
that usesBaseLoadingErrorScreen
and tie it with the business logic.How to test:
Describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.