[#172992621] Adds the available list screen and load the available bonuses #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrisTofani
requested review from
francescopersico,
matteodesanti and
Undermaken
as code owners
Affected stories
Generated by 🚫 dangerJS |
Undermaken
suggested changes
May 27, 2020
locales/en/index.yml
Outdated
| @@ -1238,6 +1238,9 @@ bonus: | |||
| bonusVacanza: | |||
| checkBonusEligibility: | |||
| loading: Checking bonus eligibility | |||
| bonusList: | |||
| title: Bonus disponibili | |||
ts/navigation/WalletNavigator.ts
Outdated
| }, | ||
|
|
||
| // Navigator section for Bonus section | ||
| [ROUTES.AVAILABLE_BONUS_LIST]: { |
There was a problem hiding this comment.
Suggested change
| [ROUTES.AVAILABLE_BONUS_LIST]: { | |
| [ROUTES.BONUS_AVAILABLE_BONUSES]: { |
Perhaps having BONUS prefix for all bonus screens could be better when we trace them in Mixpanel
There was a problem hiding this comment.
Yep, sounds good! I'm changing it.
There was a problem hiding this comment.
Maybe just BONUS_AVAILABLE_LIST could be less redundant?
Undermaken
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description:
This PR adds the Available bonuses list screen and displays the active bonus if a bonus was already activated
List of changes proposed in this pull request:
How to test:
Activate the flag
BONUS_VACANZE_ENABLEDon.envfile then on wallet home screen click onRequest new bonusbutton.