Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#172625344] Change icons order for base header #1812

Merged
merged 2 commits into from
Aug 11, 2020

Conversation

fabriziofff
Copy link
Contributor

Short description:
This pr changes the order of the icons in the top header.

Now the order is (left to right): Search icon (if available), Message icon (if available) and help icon.

List of changes proposed in this pull request:

  • Swap the icon order in BaseHeader

@pagopa-github-bot
Copy link
Collaborator

Affected stories

  • 🐞 #172625344: [trivial] Come CIT vorrei vedere le icone della header sempre nella stessa posizione

Generated by 🚫 dangerJS

@Undermaken Undermaken requested a review from CrisTofani as a code owner August 11, 2020 08:22
@pagopa-github-bot pagopa-github-bot changed the title [#172625344] Change icons order for base header fix: [#172625344] Change icons order for base header Aug 11, 2020
@pagopa-github-bot
Copy link
Collaborator

Affected stories

  • 🐞 #172625344: [trivial] Come CIT vorrei vedere le icone della header sempre nella stessa posizione

Generated by 🚫 dangerJS against 5af3dee

@codecov-commenter
Copy link

Codecov Report

Merging #1812 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1812   +/-   ##
=======================================
  Coverage   44.85%   44.85%           
=======================================
  Files         466      466           
  Lines       14362    14362           
  Branches     2704     2704           
=======================================
  Hits         6442     6442           
  Misses       7877     7877           
  Partials       43       43           
Impacted Files Coverage Δ
ts/components/screens/BaseHeader.tsx 25.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46b95a9...5af3dee. Read the comment docs.

@Undermaken Undermaken merged commit e2f6a3f into master Aug 11, 2020
@Undermaken Undermaken deleted the 172625344-reorder-header-icons-position branch August 11, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants