[Bug] Stakeout should trigger if the enemy switches with U-Turn/etc #4918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DayKev
added
Move
65 tasks
innerthunder
approved these changes
Nov 19, 2024
frutescens
approved these changes
Nov 28, 2024
torranx
reviewed
Nov 28, 2024
| @@ -5948,7 +5948,7 @@ export function initAbilities() { | |||
| .bypassFaint() | |||
| .partial(), // Meteor form should protect against status effects and yawn | |||
| new Ability(Abilities.STAKEOUT, 7) | |||
| .attr(MovePowerBoostAbAttr, (user, target, move) => user?.scene.currentBattle.turnCommands[target?.getBattlerIndex() ?? BattlerIndex.ATTACKER]?.command === Command.POKEMON, 2), | |||
| .attr(MovePowerBoostAbAttr, (user, target, move) => !!target?.turnData.switchedInThisTurn, 2), | |||
There was a problem hiding this comment.
I believe switchedInThisTurn is boolean, does this still require a double bang?
There was a problem hiding this comment.
Iirc it was because target could be null and/or undefined (hence the ?), I'll double-check though.
There was a problem hiding this comment.
I'm talking about the !! which is used to convert it to boolean - but it already is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
Stakeout will now trigger when a Pokémon switches in from U-Turn/etc.
Why am I making these changes?
Move is bugged, see #3503 (comment)
What are the changes from a developer perspective?
Trigger condition for Stakeout changed to use the recently added
PokemonTurnData.switchedInThisTurn, tests added.How to test the changes?
npm run test stakeoutChecklist
betaas my base branch[ ] Have I tested the changes manually?npm run test)npm run create-test) or updated existing tests related to the PR's changes?[ ] Have I provided screenshots/videos of the changes (if applicable)?[ ] Have I made sure that any UI change works for both UI themes (default and legacy)?