Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Mark Rage Fist as partial in line with similar moves/abilities #4894

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

DayKev
Copy link
Collaborator

@DayKev DayKev commented Nov 17, 2024

What are the changes the user will see?

Rage Fist will now be marked "(P)".

Why am I making these changes?

Rage Fist should be marked P in accordance with Balance's Decision on Last Respects, Supreme Overlord, that it should not be resetting per wave as it does currently

What are the changes from a developer perspective?

Added .partial() // Counter resets every wave instead of on arena reset to Rage Fist.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • [ ] Have I considered writing automated tests for the issue?
  • [ ] If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • [ ] Are the changes visual?
    • [ ] Have I provided screenshots/videos of the changes?

@DayKev DayKev added Move Affects a move Miscellaneous Changes that don't fit under any other label labels Nov 17, 2024
@DayKev DayKev requested a review from a team as a code owner November 17, 2024 06:16
@DayKev DayKev merged commit 2b64ef6 into pagefaultgames:beta Nov 29, 2024
13 checks passed
@DayKev DayKev deleted the rage-fist-partial branch November 29, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Miscellaneous Changes that don't fit under any other label Move Affects a move
Development

Successfully merging this pull request may close these issues.

4 participants