[Move] Spectral Thief Full Implementation

[geeilhan]

What are the changes the user will see?

Spectral Thief now steals the stat changes correctly.

Why am I making these changes?

(#3503)

What are the changes from a developer perspective?

Added a SpectralThiefAttr which extends a new StatChangeBeforeDmgCalcAttr that applies Stat Stage changes before damage calculation.

Ability Attributes such as Contrary and Simple are applied correctly since the stat changes happen through the StatStageChangePhase.

I would also like a message to pop up if stats are stolen correctly. I added the english text here public/locales/en/move-trigger.json. Do I need to push it for the other languages too?

target.scene.queueMessage(i18next.t("moveTriggers:stolePositiveStatChanges", { pokemonName: getPokemonNameWithAffix(user), targetName: getPokemonNameWithAffix(target) }));

https://github.com/geeilhan/pokerogueFork/blob/590f66e09f61f2163534d265d21b84048175cfe2/src/data/move.ts#L4367-L4368

Screenshots/Videos

Before Spectral Thief implementation:

spectral-thief-implementation-before.webm

After Spectral Thief implementation:

spectral-thief-implementation-after.webm

How to test the changes?

added automated tests for

• Basic Use
• Substitute Interaction
• Protect Interaction
• Clear Body, White Smoke and Hyper Cutter Interaction
• Simple Interaction
• Contrary Interaction
• Check if Dmg is calculated after stat changes

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I considered writing automated tests for the issue?
• If I have text, did I make it translatable and add a key in the English locale file(s)?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)
• Are the changes visual?
  • Have I provided screenshots/videos of the changes?