[Move] Corrosive Gas

[muscode13]

Locales PR

What are the changes the user will see?

Corrosive Gas will be usable in game

Why am I making these changes?

Corrosive Gas is currently unimplemented

What are the changes from a developer perspective?

• isNullified, nullify(), removedNullification added to PokemonHeldItemModifier in modifier.ts, alongside checks to shouldApply and match. This will nullify the held item and prevent it's effects from working. I thought this would be the best way to simulate Corrosive Gas' taking an item away then returning it at BattleEnd. I believe this can also be used for other unimplemented moves like Embargo and Magic Room in the future. In the second pass I added maxBattles and battleCount to disable the item for the next N waves. I add a countdown in red text and tint the item gray when nullified in getIcon.
• NullifyHeldItemAttr - applies nullify on a random item modifier. This affect lasts until the end of the turn. It has all the same ability attrs as Knock Off or Incinerate, since Corrosive Gas technically removes the item.
• In battle-end-phase.ts I added the lapse for PokemonHeldItemModifier when the item is nullified

Screenshots/Videos

Basic Flow:

basicflow2.mp4

The following videos were recorded before the UI change (pokemon icon darkening along with item icon):

Effect lasts on switch:

switch.mp4

Sticky Hold Interaction:

stickyhold.mp4

Substitute interaction:

sub.mp4

Untransferable Item interaction:

untransfer.mp4

How to test the changes?

• Use npm run test corrosive_gas
• Use Corrosive Gas in-game

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
• Have I considered writing automated tests for the issue?
• If I have text, did I make it translatable and add a key in the English locale file(s)?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)
• Are the changes visual?
  • Have I provided screenshots/videos of the changes?

[innerthunder]

Putting my comments from the Discord here for visibility:

Also, seeing that we're going with a custom implementation, you might need to make another locale PR updating Corrosive Gas's move description.

[muscode13]

@innerthunder Added the changes you suggested. Let me know what you think! (Also added new videos to show the tint)

[innerthunder]

@innerthunder Added the changes you suggested. Let me know what you think! (Also added new videos to show the tint)

Hmm... would it be possible to darken both the Pokemon icon and the item icon? I think just darkening the item is a bit difficult to notice.

[muscode13]

@innerthunder Added the changes you suggested. Let me know what you think! (Also added new videos to show the tint)

Hmm... would it be possible to darken both the Pokemon icon and the item icon? I think just darkening the item is a bit difficult to notice.

Added darkened pokemon icon, I updated the first video with an example of it.