Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ability] Partially Implement Infiltrator #4636

Merged
merged 6 commits into from
Oct 22, 2024

Conversation

innerthunder
Copy link
Collaborator

What are the changes the user will see?

This partially implements Infiltrator. Infiltrator now doesn't bypass the effects of Mist, but otherwise functions as expected.

Why am I making these changes?

Less (N) moves (even though technically this should've been marked (P) after the Substitute implementation)

What are the changes from a developer perspective?

  • data/ability: New InfiltratorAbAttr flags Light Screen, Reflect, Aurora Veil, Safeguard, and Substitute as "bypassed" when they would otherwise be applied.
  • field/pokemon: New isSafeguarded function to check if a Pokemon is under the effects of Safeguard when defending against another Pokemon's move.
  • data/arena-tag and data/move: Relevant tags and functions have been updated to apply the attacker's InfiltratorAbAttr and cancel or bypass effects.
  • test/abilities/infiltrator.test: New integration tests for Infiltrator against all relevant field effects and Substitute (Mist test currently skipped)

Screenshots/Videos

How to test the changes?

npm run test infiltrator

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • [?] Are the changes visual?
    • [?] Have I provided screenshots/videos of the changes?

@innerthunder innerthunder added Move Affects a move Ability Affects an ability and removed Move Affects a move labels Oct 11, 2024
@innerthunder innerthunder marked this pull request as draft October 15, 2024 09:33
@innerthunder
Copy link
Collaborator Author

Converting to draft... gonna wait on #4659 to update

@innerthunder innerthunder marked this pull request as ready for review October 17, 2024 05:41
@Tempo-anon Tempo-anon merged commit c2eb9de into pagefaultgames:beta Oct 22, 2024
13 checks passed
@innerthunder innerthunder deleted the infiltrator branch October 23, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ability Affects an ability
Development

Successfully merging this pull request may close these issues.

3 participants