Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Pollen Puff behavior fix #4615

Merged
merged 4 commits into from
Oct 10, 2024
Merged

[Bug] Pollen Puff behavior fix #4615

merged 4 commits into from
Oct 10, 2024

Conversation

frutescens
Copy link
Collaborator

@frutescens frutescens commented Oct 8, 2024 •
edited
Loading

Cat in front of keyboard will update later. Sorry.

What are the changes the user will see?

Pollen Puff won't damage an ally before healing it.

Why am I making these changes?

#4594

What are the changes from a developer perspective?

image
New Parameter in pokemon.apply() that takes in the move category.

Screenshots/Videos

freecompress-Screen.Recording.2024-10-08.at.7.58.08.AM.mp4

How to test the changes?

Use Pollen Puff.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I considered writing automated tests for the issue?
  • If I have text, did I make it translatable and add a key in the English locale file(s)?
  • Have I tested the changes (manually)?
    • Are all unit tests still passing? (npm run test)
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@frutescens frutescens added (Legacy) Bug Legacy Label, don't apply to new issues/PRs P2 Bug Minor. Non crashing Incorrect move/ability/interaction labels Oct 8, 2024
@frutescens frutescens requested a review from a team as a code owner October 8, 2024 15:01
Tempo-anon
Tempo-anon requested changes Oct 8, 2024
View reviewed changes
src/field/pokemon.ts Outdated Show resolved Hide resolved
@DayKev DayKev linked an issue Oct 9, 2024 that may be closed by this pull request
[Bug] Pollen Puff Damages Ally Before Healing #4594
Closed
innerthunder
innerthunder reviewed Oct 9, 2024
View reviewed changes
src/field/pokemon.ts Outdated Show resolved Hide resolved
@DayKev DayKev added Move Affects a move and removed (Legacy) Bug Legacy Label, don't apply to new issues/PRs labels Oct 9, 2024
@Tempo-anon Tempo-anon merged commit 51894d4 into pagefaultgames:beta Oct 10, 2024
13 checks passed
@DayKev DayKev mentioned this pull request Oct 21, 2024
Open
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerthunder innerthunder innerthunder approved these changes

@Tempo-anon Tempo-anon Tempo-anon approved these changes

@DayKev DayKev DayKev approved these changes

@pom-eranian pom-eranian Awaiting requested review from pom-eranian pom-eranian is a code owner automatically assigned from pagefaultgames/junior-dev-team

@MokaStitcher MokaStitcher Awaiting requested review from MokaStitcher

Assignees
No one assigned
Labels
Move Affects a move P2 Bug Minor. Non crashing Incorrect move/ability/interaction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Pollen Puff Damages Ally Before Healing
5 participants
@frutescens @DayKev @MokaStitcher @Tempo-anon @innerthunder