-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Move] Implement Fling #2200
Closed
Closed
[Move] Implement Fling #2200
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3e4b198
working on fling
AyushBarik cd8805f
implemented fling
AyushBarik 8124168
Merge branch 'pagefaultgames:main' into flingImplementation
AyushBarik cb3da4c
Merge branch 'pagefaultgames:main' into flingImplementation
AyushBarik df8caa7
Addressed most of the review comments: Got rid of evolutionary items,…
AyushBarik 18b8394
Merge branch 'pagefaultgames:main' into flingImplementation
AyushBarik 37d6428
Implemented all feedback from Tempo-anon. Tsdoc created for class and…
AyushBarik 004a3a7
Merge branch 'pagefaultgames:main' into flingImplementation
AyushBarik e1586e9
Merge branch 'pagefaultgames:main' into flingImplementation
AyushBarik a6807e5
implemented changes suggested by orangered
AyushBarik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary? Doesn't the game just show "But it failed" if you don't have a valid item?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary, I just thought it would be useful. The user might have held items, but might be wondering why fling failed. this message tells them that their items are not flingable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Since you're validating against the names of items does this work correctly in different locales?"
I tried running the game in other languages and fling does not seem to work... How do i fix this issue?