[Move] Implement Fling #2200

AyushBarik · 2024-06-14T11:13:08Z

What are the changes?

The user can now utilize the move fling.

Why am I doing these changes?

It is an important move in the game.

Greater diversity of available moves, which enhances user experience.

What did change?

The move fling is now fully functional.

Screenshots/Videos

fling.mp4

How to test the changes?

I made use of src/overrides.ts to test different items. I did not introduce automated tests.
I carried out tests on various items and confirmed functionality. If there is an issue, it may be in
determining which items are able to be flung and which are not. You may want to check my arrays
to see if the items are appropriately sorted. You can also go through the code and try to see
if the logic makes sense. I left behind some comm

My Discord username is bgjormungandr, I'm on the pokerogue server. Feel free to contact me there if needed.

Checklist

[ yes] There is no overlap with another PR?
[ yes] The PR is self-contained and cannot be split into smaller PRs?
[ yes] Have I provided a clear explanation of the changes?
[ yes] Have I tested the changes (manually)?
- [did not implement tests] Are all unit tests still passing? (npm run test)
[ yes] Are the changes visual?
- [yes ] Have I provided screenshots/videos of the changes?

hayuna · 2024-06-14T11:16:56Z

Could you update title of this PR?

[Move] Implement Fling

Arxalc · 2024-06-15T20:37:41Z

I see why you included all the item names, but since most of them aren't currently in PokeRogue, I'd just comment them out and let someone else add them in once the item is implemented in the future.

You can completely get rid of evolutionary stones. Pokemon don't hold those.

src/data/move.ts

… heldItems check moved to the beginning, dealt with berries without importing berry-type.ts

AyushBarik · 2024-06-16T17:09:53Z

Changes made as per the Suggestions:

Got rid of evolutionary items as flingable items
heldItems check moved to the beginning of the function
Dealt with berries without importing berry-type.ts

Changes not made:

I was suggested to move the validHeldItems check at the end of the else-if statements but I felt that may cause bugs so I have not implemented it for now

Additionally, as for commenting out unimplemented items from the list of flingable items - I am not sure which items have or have not been implemented. Perhaps someone more familiar with the game can change the arrays accordingly.

…mentation of fling (see PR pagefaultgames#2200)

src/data/move.ts

… apply, Unnessesary comments removed, getMyHeldItems removed as a function and made inline.

AyushBarik

Implemented all feedback from Tempo-anon:

tsdoc created for class and apply
unnecessary comments removed
getMyHeldItems removed as a function and made inline instead.

OrangeRed · 2024-06-21T18:05:09Z

src/data/move.ts

+    const arr10i = [
+      "Sitrus Berry", "Lum Berry", "Enigma Berry", "Liechi Berry", "Ganlon Berry", "Petaya Berry", "Apicot Berry", "Salac Berry",
+      "Lansat Berry", "Starf Berry", "Leppa Berry", "Choice Band", "Choice Scarf", "Choice Specs", "Air Balloon", "Absorb Bulb", "Amulet Coin", "Big Root",
+      "Destiny Knot", "Expert Belt", "Focus Band", "Focus Sash", "Lagging Tail", "Leftovers", "Mental Herb",
+      "Muscle Band", "Power Herb", "Red Card", "Shed Shell", "Silk Scarf", "Silver Powder", "Smooth Rock", "Soft Sand",
+      "Soothe Bell", "White Herb", "Wide Lens", "Wise Glasses", "Zoom Lens"
+    ];
+    const arr30i = [
+      "Flame Orb", "Yellow Flute", "Amulet Coin", "Binding Band", "Black Belt", "Black Glasses", "Black Sludge", "Cell Battery",
+      "Charcoal", "Eject Button", "Escape Rope", "Exp. Share",
+      "Float Stone", "Heart Scale", "King's Rock", "Life Orb", "Light Ball", "Light Clay",
+      "Lucky Egg", "Luminous Moss", "Magnet", "Metal Coat", "Metronome", "Miracle Seed",
+      "Mystic Water", "NeverMeltIce", "Pearl", "Poké Doll", "Razor Fang", "Scope Lens", "Shell Bell",
+      "Smoke Ball", "Snowball", "Spell Tag", "Stardust", "Toxic Orb",
+      "Twisted Spoon"];
+    const arr40i = ["Eviolite", "Icy Rock"];
+    const arr50i = ["Sharp Beak"];
+    const arr60i = ["Damp Rock", "Heat Rock", "Macho Brace", "Rocky Helmet"];
+    const arr70i = ["Dragon Fang", "Poison Barb", "Power Anklet", "Power Band", "Power Belt", "Power Bracer",
+      "Power Lens", "Power Weight"];
+    const arr80i = [
+      "Assault Vest", "Quick Claw", "Razor Claw",
+      "Sachet", "Safety Goggles", "Sticky Barb",
+      "Weakness Policy"
+    ];
+    const arr90i = ["Grip Claw"];
+    const arr100i = ["Hard Stone"];
+    const arr130i = ["Iron Ball"];


Instead of making huge arrays of item names like this wouldn't it be better to just add the flingPower / weight of the item onto that item's class (ModifierType)?

src/data/move.ts

AyushBarik · 2024-06-27T08:23:36Z

NoValidHeldItems.2.mov

Video that displays the functionality of fling as well as the case if none of the held items possessed by the Pokemon are flingable. (For testing purposes flame orb was made unflingable temporarily).

AyushBarik · 2024-06-27T08:30:52Z

noHeldItems.1.mov

Displays what happens if the user has no held items

OrangeRed

Since you're validating against the names of items does this work correctly in different locales?

OrangeRed · 2024-06-27T17:34:45Z

src/data/move.ts

+    if (validHeldItems.length === 0) {
+      return "No valid held items!";
+    }


Is this necessary? Doesn't the game just show "But it failed" if you don't have a valid item?

Not necessary, I just thought it would be useful. The user might have held items, but might be wondering why fling failed. this message tells them that their items are not flingable.

"Since you're validating against the names of items does this work correctly in different locales?"

I tried running the game in other languages and fling does not seem to work... How do i fix this issue?

…mentation of fling (see PR pagefaultgames#2200)

Tempo-anon

This does not work since it's checking for hardcoded english names. Could we not update modifier-type.ts to include the relevant type and damage info while just having the special effects in the FlingAttr?

flx-sta · 2024-09-17T16:19:19Z

@AyushBarik closed for being stale (no updates for over a month)

Feel free to create a new PR or ask us to re-open this one.

working on fling

3e4b198

Tempo-anon added the Ability Affects an ability label Jun 14, 2024

AyushBarik and others added 2 commits June 15, 2024 23:36

implemented fling

cd8805f

Merge branch 'pagefaultgames:main' into flingImplementation

8124168

AyushBarik changed the title ~~Working on the move fling. Currently a work in progress.~~ [Move] Implement Fling Jun 15, 2024

AyushBarik marked this pull request as ready for review June 15, 2024 19:12

Arxalc reviewed Jun 15, 2024

View reviewed changes

src/data/move.ts Outdated Show resolved Hide resolved

src/data/move.ts Outdated Show resolved Hide resolved

src/data/move.ts Outdated Show resolved Hide resolved

src/data/move.ts Show resolved Hide resolved

Tempo-anon added Move Affects a move and removed Ability Affects an ability labels Jun 16, 2024

AyushBarik and others added 2 commits June 16, 2024 22:28

Merge branch 'pagefaultgames:main' into flingImplementation

cb3da4c

Addressed most of the review comments: Got rid of evolutionary items,…

df8caa7

… heldItems check moved to the beginning, dealt with berries without importing berry-type.ts

Merge branch 'pagefaultgames:main' into flingImplementation

18b8394

AyushBarik added a commit to AyushBarik/pokerogue that referenced this pull request Jun 17, 2024

working on natural gift. Part of thework will be copied from my imple…

c1d5d7e

…mentation of fling (see PR pagefaultgames#2200)

Tempo-anon reviewed Jun 17, 2024

View reviewed changes

src/data/move.ts Outdated Show resolved Hide resolved

Tempo-anon reviewed Jun 17, 2024

View reviewed changes

src/data/move.ts Outdated Show resolved Hide resolved

Tempo-anon reviewed Jun 17, 2024

View reviewed changes

src/data/move.ts Outdated Show resolved Hide resolved

Implemented all feedback from Tempo-anon. Tsdoc created for class and…

37d6428

… apply, Unnessesary comments removed, getMyHeldItems removed as a function and made inline.

AyushBarik force-pushed the flingImplementation branch from 6d730ce to 37d6428 Compare June 17, 2024 15:33

AyushBarik commented Jun 17, 2024

View reviewed changes

OrangeRed suggested changes Jun 21, 2024

View reviewed changes

AyushBarik and others added 3 commits June 26, 2024 19:53

Merge branch 'pagefaultgames:main' into flingImplementation

004a3a7

Merge branch 'pagefaultgames:main' into flingImplementation

e1586e9

implemented changes suggested by orangered

a6807e5

OrangeRed reviewed Jun 27, 2024

View reviewed changes

f-fsantos changed the base branch from main to beta July 10, 2024 17:47

AyushBarik added a commit to AyushBarik/pokerogue that referenced this pull request Jul 29, 2024

working on natural gift. Part of thework will be copied from my imple…

e73014d

…mentation of fling (see PR pagefaultgames#2200)

Tempo-anon requested changes Jul 30, 2024

View reviewed changes

frutescens mentioned this pull request Aug 12, 2024

List of Partial / Unimplemented Moves and Abilities #3503

Open

65 tasks

flx-sta closed this Sep 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Move] Implement Fling #2200

[Move] Implement Fling #2200

AyushBarik commented Jun 14, 2024 •

edited

Loading

hayuna commented Jun 14, 2024

Arxalc commented Jun 15, 2024

AyushBarik commented Jun 16, 2024

AyushBarik left a comment

OrangeRed Jun 21, 2024

AyushBarik commented Jun 27, 2024 •

edited

Loading

AyushBarik commented Jun 27, 2024

OrangeRed left a comment

OrangeRed Jun 27, 2024

AyushBarik Jun 28, 2024

AyushBarik Jun 28, 2024

Tempo-anon left a comment

flx-sta commented Sep 17, 2024

[Move] Implement Fling #2200

[Move] Implement Fling #2200

Conversation

AyushBarik commented Jun 14, 2024 • edited Loading

What are the changes?

Why am I doing these changes?

What did change?

Screenshots/Videos

How to test the changes?

Checklist

hayuna commented Jun 14, 2024

Arxalc commented Jun 15, 2024

AyushBarik commented Jun 16, 2024

AyushBarik left a comment

Choose a reason for hiding this comment

OrangeRed Jun 21, 2024

Choose a reason for hiding this comment

AyushBarik commented Jun 27, 2024 • edited Loading

AyushBarik commented Jun 27, 2024

OrangeRed left a comment

Choose a reason for hiding this comment

OrangeRed Jun 27, 2024

Choose a reason for hiding this comment

AyushBarik Jun 28, 2024

Choose a reason for hiding this comment

AyushBarik Jun 28, 2024

Choose a reason for hiding this comment

Tempo-anon left a comment

Choose a reason for hiding this comment

flx-sta commented Sep 17, 2024

AyushBarik commented Jun 14, 2024 •

edited

Loading

AyushBarik commented Jun 27, 2024 •

edited

Loading