Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Hustle's Accuracy is not improved by Wide Lens #4934

Open
Snailman11 opened this issue Nov 23, 2024 · 0 comments
Open

[Bug] Hustle's Accuracy is not improved by Wide Lens #4934

Snailman11 opened this issue Nov 23, 2024 · 0 comments
Labels
Ability Affects an ability Item Affects an item P2 Bug Minor. Non crashing Incorrect move/ability/interaction

Comments

@Snailman11
Copy link
Collaborator

Snailman11 commented Nov 23, 2024

Describe the bug

A move Affected by both Hustle and Wide Lens has a much lower Accuracy rate than it should

Link to Discord's Bug Report (Hustle not working with wide lens)
https://discord.com/channels/1125469663833370665/1309735047258968165

In Pokerogue, Wide Lens modifies moveAccuracy (the base accuracy of a single move)

override apply(_pokemon: Pokemon, moveAccuracy: NumberHolder): boolean {

  override apply(_pokemon: Pokemon, moveAccuracy: NumberHolder): boolean {
    moveAccuracy.value = Math.min(moveAccuracy.value + this.accuracyAmount * this.getStackCount(), 100);

    return true;
  }

  getMaxHeldItemCount(pokemon: Pokemon): number {
    return 3;
  }
}

Hustle seems to target the Accuracy Stat instead

https://github.com/pagefaultgames/pokerogue/blob/6442b8345ff2f5860610f521a48704627b445fce/src/data/ability.ts#L5497C2-L5499C117

   new Ability(Abilities.HUSTLE, 3)
      .attr(StatMultiplierAbAttr, Stat.ATK, 1.5)
      .attr(StatMultiplierAbAttr, Stat.ACC, 0.8, (_user, _target, move) => move.category === MoveCategory.PHYSICAL),

The result of this would be a move's accuracy being modified first (not in accordance with mainline or Plasto's wishes) and Hustle being considered afterwards. Which results in Pokerogue's accuracy Equation being like this:

Icicle Crash{85} + 3(Wide Lens{5}) x Hustle{0.8} = 80% or Tackle{100} + 3(Wide Lens{5}) x Hustle{0.8} = 80%

Whereas if Hustle is instead considered before Wide Lens, you end up with an equation like this

Icicle Crash{85} x Hustle{0.8} + 3(Wide Lens{5}) = 83% or Tackle{100} x Hustle{0.8} + 3(Wide Lens{5}] = 95%

Reproduction

Use Wide Lens on a Pokémon with Hustle and use physical moves.

Expected behavior

The way Wide Lens works in mainline is as a flat percentage of the calculated accuracy after abilities and move effects have been considered.

Screenshot (455)
(Throat Chop{100%} x Hustle{80%} x Wide Lens{10%}) = 88% Chance to Hit

Balance Team member Plasto suggests that Hustle and Wide Lens should interact in Pokerogue
https://discord.com/channels/1125469663833370665/1260369966314688602/1309750190273466509

Screenshots / Videos

No response

Session export file

No response

User data export file

No response

Additional context

The Description of Wide Lens is not great and I think it could be improved if this is changed
"Increases move accuracy by 5 (maximum 100)"
it just feels like it's trying to imply too much, and changing it to apply after Hustle might make the description obsolete

@Snailman11 Snailman11 added Ability Affects an ability Item Affects an item P2 Bug Minor. Non crashing Incorrect move/ability/interaction labels Nov 23, 2024
@Snailman11 Snailman11 moved this from To triage to Ready in PokéRogue Bug Management Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ability Affects an ability Item Affects an item P2 Bug Minor. Non crashing Incorrect move/ability/interaction
Projects
Status: Ready
Development

No branches or pull requests

1 participant