Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Some immune message from Ability is not showing #3006

Open
EnochG1 opened this issue Jul 13, 2024 · 1 comment
Open

[BUG] Some immune message from Ability is not showing #3006

EnochG1 opened this issue Jul 13, 2024 · 1 comment
Labels
Ability Affects an ability P2 Bug Minor. Non crashing Incorrect move/ability/interaction

Comments

@EnochG1
Copy link
Contributor

EnochG1 commented Jul 13, 2024

Describe the bug
At src/data/ability.ts,
some immune ability(ignores something) has getTriggerMessage() to show message, but it doesn't seem to be triggered.

  • NonSuperEffectiveImmunityAbAttr : WONDER_GUARD // can't see abilityBar, message is 'But it failed!'
  • StatusEffectImmunityAbAttr : LIMBER, INSOMNIA, IMMUNITY, MAGMA_ARMOR, WATER_VEIL, VITAL_SPIRIT, LEAF_GUARD, SWEET_VEIL, WATER_BUBBLE, COMATOSE, PASTEL_VEIL, THERMAL_EXCHANGE, PURIFYING_SALT
  • BattlerTagImmunityAbAttr : OBLIVIOUS, INSOMNIA, OWN_TEMPO, INNER_FOCUS, VITAL_SPIRIT, SWEET_VEIL, COMATOSE

To Reproduce

  1. Go to 'main' branch
  2. Change overrides.ts to reproduce immune case.
  • For example, to show OBLIVIOUS ability prevents ATTRACT
export const ABILITY_OVERRIDE: Abilities = Abilities.OBLIVIOUS;
export const GENDER_OVERRIDE: Gender = Gender.MALE;
export const OPP_GENDER_OVERRIDE: Gender = Gender.FEMALE;
export const OPP_MOVESET_OVERRIDE: Array<Moves> = [Moves.ATTRACT, Moves.ATTRACT, Moves.ATTRACT, Moves.ATTRACT];
  1. Then check if ability is triggered.
  2. Even though you can see abilityBar, getTriggerMessage() is not showing, like
  getTriggerMessage(pokemon: Pokemon, abilityName: string, ...args: any[]): string {
    return getPokemonMessage(pokemon, `'s ${abilityName}\nprevents ${(args[0] as BattlerTag).getDescriptor()}!`);
  }

Expected behavior
getTriggerMessage() works to inform the user.

Screenshots / Videos
image

Device
Chrome (But I guess it doesn't matter)

Additional context
N/A

@EnochG1 EnochG1 added the (Legacy) Bug Legacy Label, don't apply to new issues/PRs label Jul 13, 2024
@Snailman11 Snailman11 reopened this Aug 27, 2024
@Snailman11
Copy link
Collaborator

Snailman11 commented Aug 27, 2024

#1160 (Abilities that prevent sleep don't show the pop-up banner)
Similar, might be duplicate

Video of sweet veil

Sweet.Veil.no.message.mp4

@Snailman11 Snailman11 added the Ability Affects an ability label Aug 27, 2024
@Snailman11 Snailman11 added P2 Bug Minor. Non crashing Incorrect move/ability/interaction and removed (Legacy) Bug Legacy Label, don't apply to new issues/PRs labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ability Affects an ability P2 Bug Minor. Non crashing Incorrect move/ability/interaction
Projects
Status: Ready
Development

No branches or pull requests

2 participants