Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook status takes into consideration removed webhooks #568

Closed
ruben-perez opened this issue Jul 5, 2022 · 0 comments
Closed

Webhook status takes into consideration removed webhooks #568

ruben-perez opened this issue Jul 5, 2022 · 0 comments

Comments

@ruben-perez
Copy link

Description

Trying to get my Pact Broker set with the needed webhook configuration, I have spotted a scenario in which removing webhooks has some side effects.

Once you remove a webhook and create a new one, the triggered webhook executions are kept in the Broker DB, and are taken into consideration while trying to get the webhook status for a given contract.

That means that is somehow the last execution of the old/removed webhook for a given contract ended with a non-successful state, the webhook status will take it anyway into consideration while trying to get the webhook status for the UI. And that means that for that given contract, the UI will always show a non-successful state as a result, even when the new webhook is working well and the tests are passing.

Maybe the logic to get the webhook status for a given contract should only take into consideration the current webhooks and not the ones that were deleted.

Software versions

Behaviour seen in pactfoundation/pact-broker:2.101.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant