Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add duplicate detection for new publish pacts endpoint #546

Closed
bethesque opened this issue Feb 22, 2022 · 1 comment
Closed

Add duplicate detection for new publish pacts endpoint #546

bethesque opened this issue Feb 22, 2022 · 1 comment
Assignees

Comments

@bethesque
Copy link
Member

bethesque commented Feb 22, 2022

Duplicates are happening already. See #539

The logic already exists here

def self.find_potential_duplicate_pacticipants pacticipant_name

A call to this method needs to happen in the conflict_notices method in the contract service here https://github.com/pact-foundation/pact_broker/blob/master/lib/pact_broker/contracts/service.rb#L46 and an appropriate message added.

@bethesque
Copy link
Member Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants