thin missing as development dependency

[pkubowicz]

Pre issue-raising checklist

I have already (please mark the applicable with an x):

• Upgraded to the latest Pact Broker OR
• Checked the CHANGELOG to see if the issue I am about to raise has been fixed

Software versions

• pact-broker repository commit: f57184e
• OS: Ubuntu 18.04.1 LTS
• ruby 2.5.1p5

Expected behaviour

I can follow DEVELOPER_SETUP.md.

Actual behaviour

% bundle exec rake pact_broker:dev:setup
BUNDLE_GEMFILE=dev/Gemfile bundle install
Traceback (most recent call last):
        14: from /usr/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:in `require'
        13: from /usr/lib/ruby/2.5.0/rubygems/core_ext/kernel_require.rb:59:in `require'
        12: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/setup.rb:20:in `<top (required)>'
        11: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler.rb:107:in `setup'
        10: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:20:in `setup'
         9: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/runtime.rb:108:in `block in definition_method'
         8: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/definition.rb:227:in `requested_specs'
         7: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/definition.rb:238:in `specs_for'
         6: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/definition.rb:171:in `specs'
         5: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/definition.rb:259:in `resolve'
         4: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/resolver.rb:22:in `resolve'
         3: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/resolver.rb:49:in `start'
         2: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/resolver.rb:255:in `verify_gemfile_dependencies_are_found!'
         1: from /var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/resolver.rb:255:in `each'
/var/lib/gems/2.5.0/gems/bundler-1.16.6/lib/bundler/resolver.rb:287:in `block in verify_gemfile_dependencies_are_found!': Could not find gem 'thin (~> 1.7)' in any of the gem sources listed in your Gemfile. (Bundler::GemNotFound)

Workaround is to add

gem.add_development_dependency 'thin', '~> 1.7'

to pact_broker.gemspec

Steps to reproduce

bundle install --path vendor/bundle
bundle exec rake pact_broker:dev:setup

Relevent log files

[bethesque]

The thin dependency should be coming from the dev/Gemfile, which has been copied from example/Gemfile. It does not belong in the pact_broker.gemspec. The real question is, why does the command BUNDLE_GEMFILE=dev/Gemfile bundle install not execute with the right gemfile.

[bethesque]

Try it now.

[pkubowicz]

94f3a5f fixes the issue, thanks.