Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rustls to >=0.23 #455

Open
ostrolucky opened this issue Jul 11, 2024 · 3 comments
Open

Update rustls to >=0.23 #455

ostrolucky opened this issue Jul 11, 2024 · 3 comments

Comments

@ostrolucky
Copy link

ostrolucky commented Jul 11, 2024

My employer uses Cloudflare Warp which uses ECDSA Signature with SHA-512 that is not supported by rustls 0.22.x which FFI here requires

rustls/rustls#1367
denoland/deno#21169

Please update to rustls >=0.23, which supports it so that I can use this project, as right now it's not possible for me:

Failures:

1) Failed to load pact - Failed to load pact 'https://pact-broker.eqs.dev/pacts/provider/data-center-api/consumer/control-tower-ui/latest' - Request failed - error sending request for url (https://pact-broker.eqs.dev/pacts/provider/data-center-api/consumer/control-tower-ui/latest): error trying to connect: invalid peer certificate: BadSignature
@rholshausen
Copy link
Contributor

Unfortunately, it is not that simple as just upgrading that crate. This requires an upgrade to a number of other crates as well (like tokio-rustls, reqwest and hyper-rustls) which in turn require updates to Tokio and Hyper.

Work has been started to rewrite the mock server component using Hyper 1.x, so that all these crates can be updated. That is currently a beta release. It will need to be stabilised and merged into the main first.

@YOU54F
Copy link
Member

YOU54F commented Jul 24, 2024

v2.0.0 of Pact Mock Server was released last week, out of beta, which is the first piece of the puzzle, enabling other crates to be updated

https://github.com/pact-foundation/pact-core-mock-server/releases/tag/libpact_mock_server-v2.0.0

@ostrolucky for an idea of the complexities in upgrading the project, please refer to the ecosystem diagram for the rust project

https://docs.pact.io/diagrams/ecosystem#rust-goldberg-machine

hopefully this will add some additional context to Ron's comments above, as I note your confused emoji.

@YOU54F
Copy link
Member

YOU54F commented Jul 24, 2024

Related issue which contains the rationale for the V2 pact mock server

#414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants